-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link. If when the rollback is activated, the last editor on that page is someone other than it was when the link was generated, it will throw an error message instead of blindly reverting -- usually putting the vandalism back on top. :)
This is in CVS and on test.wikipedia.org; please help shake it out a bit more before putting it live.
I've also taken the $wgDisableCounters check out of SiteStatsUpdate.php, since that had broken the article count. And, the article count should now be running on the agreed-upon link-count instead of ugly old comma-count (this change has been in the code for a while, but is only now live).
- -- brion vibber (brion @ pobox.com)
Brion-
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link. If when the rollback is activated, the last editor on that page is someone other than it was when the link was generated, it will throw an error message instead of blindly reverting -- usually putting the vandalism back on top. :)
Thanks, Brion -- I had this in my todo list but put it on hold after the freeze. Seems to work fine on test.wiki. I have updated the error messages somewhat -- please take a look. Also, the "edit comment was .." message is no longer shown when there was no edit comment.
Regards, Erik
Brion Vibber schrieb:
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link.
Cool. Could you please also add a check before deletion if a page has been edited?
And, the article count should now be running on the agreed-upon link-count instead of ugly old comma-count (this change has been in the code for a while, but is only now live).
And, how many more articles does the counter show? :-)
Kurt
Brion Vibber schrieb:
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link.
Cool. Could you please also add a check before deletion if a page has been edited?
You mean a warning if a page that is to be deleted has a history? That's already in CVS.
Regards,
Erik
On Sun, May 25, 2003 at 02:56:00PM +0200, Erik Moeller wrote:
Brion Vibber schrieb:
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link.
Cool. Could you please also add a check before deletion if a page has been edited?
You mean a warning if a page that is to be deleted has a history? That's already in CVS.
I think a warning that the page that you are going to delete has been edited since you read it might be useful.
JeLuF
On Sun, May 25, 2003 at 02:56:00PM +0200, Erik Moeller wrote:
Brion Vibber schrieb:
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link.
Cool. Could you please also add a check before deletion if a page has been edited?
You mean a warning if a page that is to be deleted has a history? That's already in CVS.
I think a warning that the page that you are going to delete has been edited since you read it might be useful.
Hmm. We could pass a revision timestamp to the delete function as an argument. If the current revision is newer, a warning could be displayed. Brion, what do you think?
Regards,
Erik
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Je Dimanĉo 25 Majo 2003 06:33, Erik Moeller skribis:
I think a warning that the page that you are going to delete has been edited since you read it might be useful.
Hmm. We could pass a revision timestamp to the delete function as an argument. If the current revision is newer, a warning could be displayed. Brion, what do you think?
Yes, that was my evil plan, but I hadn't got 'round to it.
(I put the user, rather than timestamp, on rollback since rollback works a little funny; additional edits by the same vandal are ok to roll back.)
- -- brion vibber (brion @ pobox.com)
"Erik Moeller" skribis:
Brion Vibber schrieb:
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link.
Cool. Could you please also add a check before deletion if a page has been edited?
You mean a warning if a page that is to be deleted has a history? That's already in CVS.
I don't know what Kurt means, but I think about a similar check like the one for the rollback - "is the last edit the same as it was when generating the remove-link"?
Paul
Erik Moeller schrieb:
Brion Vibber schrieb:
Now I know we're supposed to be in feature freeze, but I consider this a bug fix as it's been damn annoying. I've just checked in changes to Article.php, SpecialContributions.php, and Language.php to add a last-user-name check to the rollback link.
Cool. Could you please also add a check before deletion if a page has been edited?
You mean a warning if a page that is to be deleted has a history? That's already in CVS.
No, I ment a warning if a page has been edited between my last look at it and the deletion. Like the edit conflict check.
Often people are motivated by the garbage someone entered to write a real article. I don't want to delete it accidentally.
Kurt
I modified LanguageDe.php (in CVS) and included translations for the new texts.
(Brion Vibber brion@pobox.com):
I've also taken the $wgDisableCounters check out of SiteStatsUpdate.php,
Why remove the functionality instead of simply setting $wgDisableCounters to false?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Je Mardo 27 Majo 2003 11:59, Lee Daniel Crocker skribis:
(Brion Vibber brion@pobox.com): I've also taken the $wgDisableCounters check out of SiteStatsUpdate.php,
Why remove the functionality instead of simply setting $wgDisableCounters to false?
Because that would re-enable the individual page view counters, putting more update pressure back onto the much-abuse cur table. The granularity on the option didn't match what we've been doing.
- -- brion vibber (brion @ pobox.com)
wikitech-l@lists.wikimedia.org