* $wgSpamRegex now matches the edit summary and page move descriptions in addition to body text.
Oh no!
I must not apply my rules also to the edit summary!
How can I separate back out the functionality, without hacking more than just my LocalSettings.php?
/** Similarly you can get a function to do the job. The function will be given * the following args: * - a Title object for the article the edit is made on * - the text submitted in the textarea (wpTextbox1) * - the section number. [and there's more items that are not mentioned, see EditPage.php] * The return should be boolean indicating whether the edit matched some evilness: * - true : block it * - false : let it through * * For a complete example, have a look at the SpamBlacklist extension. */ $wgFilterCallback = false;
OK, I got as far as http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SpamBlacklist/REA... before my head started to spin.
Can somebody please tell me how to regain the previous functionality?
I assume I should remove my $wgSpamRegex, and instead use $wgFilterCallback with an array of my patterns, testing only on wpTextbox1. Is there any simple example other than http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SpamBlacklist/ Thanks.
jidanni wrote:
Can somebody please tell me how to regain the previous functionality?
I assume I should remove my $wgSpamRegex, and instead use $wgFilterCallback with an array of my patterns, testing only on wpTextbox1. Is there any simple example other than http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SpamBlacklist/ Thanks.
Seems pretty easy to ignore edit summaries on that extension. Open SpamBlacklist_body.php and delete these lines: // We add the edit summary if one exists if ( !empty( $editsummary ) ) $addedLinks[] = $editsummary;
I hacked in r47737 a "ignoreEditSummary" configuration parameter.
Update your copy, and put $wgSpamBlacklistSettings['ignoreEditSummary'] = true; in your LocalSettings.php :)
2009/2/24 Platonides Platonides@gmail.com:
jidanni wrote:
Can somebody please tell me how to regain the previous functionality?
I assume I should remove my $wgSpamRegex, and instead use $wgFilterCallback with an array of my patterns, testing only on wpTextbox1. Is there any simple example other than http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SpamBlacklist/ Thanks.
Seems pretty easy to ignore edit summaries on that extension. Open SpamBlacklist_body.php and delete these lines: // We add the edit summary if one exists if ( !empty( $editsummary ) ) $addedLinks[] = $editsummary;
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
"ND" == Nicolas Dumazet nicdumz@gmail.com writes:
ND> 2009/2/24 Platonides Platonides@gmail.com:
Platonides? I didn't see that message from Platonides here on http://news.gmane.org/gmane.science.linguistics.wikipedia.technical . But there it is in http://lists.wikimedia.org/pipermail/wikitech-l/2009-February/041667.html So Gmane users beware, we are not getting the full story.
I'll crosspost this to http://news.gmane.org/gmane.discuss . They are very attentive, and the problem will get fixed right away...
1.14.0 RELEASE-NOTES says: * $wgSpamRegex now matches the edit summary and page move descriptions in addition to body text.
I'm sorry, but that's absolutely crazy, reckless, irresponsible. See https://bugzilla.wikimedia.org/show_bug.cgi?id=17677 .
wikitech-l@lists.wikimedia.org