Hi, folks!
I just wondered whether ppl think it's a good idea to copy wiki.png to the installation path when calling the update script ("php4 update.php"). IMHO it isn't. A working setup will likely have a customized logo that it doesn't want overwritten. IMHO only code should be updated.
Alternatively we could just change the copyfile method so it doesn't abort if a file can't be written.
Any comments, criticism, ideas, hints, objections? Else I'll just comment the concerning line out.
Bye! Matthias
Matthias Jordan wrote:
I just wondered whether ppl think it's a good idea to copy wiki.png to the installation path when calling the update script ("php4 update.php"). IMHO it isn't. A working setup will likely have a customized logo that it doesn't want overwritten. IMHO only code should be updated.
a) You can set the wiki to use a different file for the logo. b) You can put your custom logo in your work source tree. c) You don't need to use update.php at all. I don't; I use a script that copies individual files into all running wikis' live script directories.
-- brion vibber (brion @ pobox.com)
Hi, folks!
Brion Vibber wrote:
a) You can set the wiki to use a different file for the logo. b) You can put your custom logo in your work source tree. c) You don't need to use update.php at all. I don't; I use a script that copies individual files into all running wikis' live script directories.
There are surely some workarounds but I doubt that they make any sense. I mean, if we provide an update script, it should do exactly this: update the wiki software. It should not update any content. Neither should it have to be replaced (?) by a custom update script (a good proof that our script is useless). I think the only usable workaround is item a) but it still is a workaround. Why should I copy an image that is not used at all to the installation path?
This issue is probably more philosophical than technical, though, but it's still an issue. Before I write my own update script I want to check if other ppl have the same problems. If they do (and it seems so) we should update the update script to make it more useful.
Bye! Matthias
wikitech-l@lists.wikimedia.org