Hello.
I wrote an extension[1] for Wikinews and Wiktionary to replace the JS-driven custom tabs (Opinions in Wikinews, Citations/Template documentation in Wiktionary).
According to the manual, as there were no "pros" heard from Design-l, now the extension must undergo a technical design review, before it is decided whether the extension is able to fly on production sites - deployment review.
-- [1] https://www.mediawiki.org/wiki/Extension:NamespaceRelations
On 02/08/2013 08:35 PM, Paul Selitskas wrote:
According to the manual, as there were no "pros" heard from Design-l, now the extension must undergo a technical design review, before it is decided whether the extension is able to fly on production sites - deployment review.
Out of curiosity, where is this in the manual?
Matt Flaschen
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen mflaschen@wikimedia.orgwrote:
On 02/08/2013 08:35 PM, Paul Selitskas wrote:
According to the manual, as there were no "pros" heard from Design-l, now the extension must undergo a technical design review, before it is
decided
whether the extension is able to fly on production sites - deployment review.
Out of curiosity, where is this in the manual?
Matt Flaschen
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment?
I suppose that means there should be a review to see if the extension design is OK to be deployed live.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:07 PM, Paul Selitskas p.selitskas@gmail.comwrote:
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen <mflaschen@wikimedia.org
wrote:
On 02/08/2013 08:35 PM, Paul Selitskas wrote:
According to the manual, as there were no "pros" heard from Design-l,
now
the extension must undergo a technical design review, before it is
decided
whether the extension is able to fly on production sites - deployment review.
Out of curiosity, where is this in the manual?
Matt Flaschen
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment?
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Well, those tabs are already used in Wikinews and Wiktionary, so I personally find no reason for design review.
On Sat, Feb 9, 2013 at 5:14 AM, Tyler Romeo tylerromeo@gmail.com wrote:
I suppose that means there should be a review to see if the extension design is OK to be deployed live.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:07 PM, Paul Selitskas <p.selitskas@gmail.com
wrote:
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen <
mflaschen@wikimedia.org
wrote:
On 02/08/2013 08:35 PM, Paul Selitskas wrote:
According to the manual, as there were no "pros" heard from Design-l,
now
the extension must undergo a technical design review, before it is
decided
whether the extension is able to fly on production sites - deployment review.
Out of curiosity, where is this in the manual?
Matt Flaschen
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment?
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
P.S. bikeshedding, guys... bikeshedding...
To be honest, I doubt that many extensions go through a ui review prior to their main review. Given that the ui components have already existed, I would reccomend you just skip to the next step of that guide If you can't find anyone. Trust me as a volunteer contributed extension it will probably get the ninth degree before it gets deployed anyhow
-bawolff On 2013-02-08 10:24 PM, "Paul Selitskas" p.selitskas@gmail.com wrote:
Well, those tabs are already used in Wikinews and Wiktionary, so I personally find no reason for design review.
On Sat, Feb 9, 2013 at 5:14 AM, Tyler Romeo tylerromeo@gmail.com wrote:
I suppose that means there should be a review to see if the extension design is OK to be deployed live.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:07 PM, Paul Selitskas <p.selitskas@gmail.com
wrote:
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen <
mflaschen@wikimedia.org
wrote:
On 02/08/2013 08:35 PM, Paul Selitskas wrote:
According to the manual, as there were no "pros" heard from
Design-l,
now
the extension must undergo a technical design review, before it is
decided
whether the extension is able to fly on production sites -
deployment
review.
Out of curiosity, where is this in the manual?
Matt Flaschen
<https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment
?
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
P.S. bikeshedding, guys... bikeshedding...
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
I agree, I'm just saying I think the guide is implying that the extension should be reviewed for security and whatnot before being deployed.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:33 PM, Brian Wolff bawolff@gmail.com wrote:
To be honest, I doubt that many extensions go through a ui review prior to their main review. Given that the ui components have already existed, I would reccomend you just skip to the next step of that guide If you can't find anyone. Trust me as a volunteer contributed extension it will probably get the ninth degree before it gets deployed anyhow
-bawolff On 2013-02-08 10:24 PM, "Paul Selitskas" p.selitskas@gmail.com wrote:
Well, those tabs are already used in Wikinews and Wiktionary, so I personally find no reason for design review.
On Sat, Feb 9, 2013 at 5:14 AM, Tyler Romeo tylerromeo@gmail.com
wrote:
I suppose that means there should be a review to see if the extension design is OK to be deployed live.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:07 PM, Paul Selitskas <p.selitskas@gmail.com
wrote:
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen <
mflaschen@wikimedia.org
wrote:
On 02/08/2013 08:35 PM, Paul Selitskas wrote:
According to the manual, as there were no "pros" heard from
Design-l,
now
the extension must undergo a technical design review, before it
is
decided
whether the extension is able to fly on production sites -
deployment
review.
Out of curiosity, where is this in the manual?
Matt Flaschen
<
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment
?
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
P.S. bikeshedding, guys... bikeshedding...
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Yes, extensions need to be reviewed (esp. In terms of security and performance) before anyone will deploy them.
-bawolff On 2013-02-08 10:35 PM, "Tyler Romeo" tylerromeo@gmail.com wrote:
I agree, I'm just saying I think the guide is implying that the extension should be reviewed for security and whatnot before being deployed.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:33 PM, Brian Wolff bawolff@gmail.com wrote:
To be honest, I doubt that many extensions go through a ui review prior
to
their main review. Given that the ui components have already existed, I would reccomend you just skip to the next step of that guide If you can't find anyone. Trust me as a volunteer contributed extension it will
probably
get the ninth degree before it gets deployed anyhow
-bawolff On 2013-02-08 10:24 PM, "Paul Selitskas" p.selitskas@gmail.com wrote:
Well, those tabs are already used in Wikinews and Wiktionary, so I personally find no reason for design review.
On Sat, Feb 9, 2013 at 5:14 AM, Tyler Romeo tylerromeo@gmail.com
wrote:
I suppose that means there should be a review to see if the extension design is OK to be deployed live.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:07 PM, Paul Selitskas <
p.selitskas@gmail.com
wrote:
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen <
mflaschen@wikimedia.org
wrote:
On 02/08/2013 08:35 PM, Paul Selitskas wrote: > According to the manual, as there were no "pros" heard from
Design-l,
now
> the extension must undergo a technical design review, before it
is
decided > whether the extension is able to fly on production sites -
deployment
> review.
Out of curiosity, where is this in the manual?
Matt Flaschen
<
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment
?
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
P.S. bikeshedding, guys... bikeshedding...
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
One weird thing I've noticed is that for some reason the extension seems to be unsetting variables when it's done using them. I can understand not wanting to pollute the local variable scope, but it's really unnecessary and probably has some sort of performance impact when you're setting and unsetting variables in a foreach loop.
Also, rather than have a separate hooks class, you can just make an object of the NamespaceRelations class in an extension setup function and register the hook using the object rather than the class name.
Also, there's a few cases of call-time passing by reference, which I'm pretty sure causes fatal errors in PHP 5.4.0 and greater.
As far as security goes, I cannot seem to find any issues, primarily because most of the actual rendering of the tabs occurs outside the scope of the extension.
If I have time tomorrow maybe I'll submit a patch or two.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Sat, Feb 9, 2013 at 2:47 AM, Brian Wolff bawolff@gmail.com wrote:
Yes, extensions need to be reviewed (esp. In terms of security and performance) before anyone will deploy them.
-bawolff On 2013-02-08 10:35 PM, "Tyler Romeo" tylerromeo@gmail.com wrote:
I agree, I'm just saying I think the guide is implying that the extension should be reviewed for security and whatnot before being deployed.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:33 PM, Brian Wolff bawolff@gmail.com wrote:
To be honest, I doubt that many extensions go through a ui review prior
to
their main review. Given that the ui components have already existed, I would reccomend you just skip to the next step of that guide If you
can't
find anyone. Trust me as a volunteer contributed extension it will
probably
get the ninth degree before it gets deployed anyhow
-bawolff On 2013-02-08 10:24 PM, "Paul Selitskas" p.selitskas@gmail.com
wrote:
Well, those tabs are already used in Wikinews and Wiktionary, so I personally find no reason for design review.
On Sat, Feb 9, 2013 at 5:14 AM, Tyler Romeo tylerromeo@gmail.com
wrote:
I suppose that means there should be a review to see if the
extension
design is OK to be deployed live.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Fri, Feb 8, 2013 at 9:07 PM, Paul Selitskas <
p.selitskas@gmail.com
wrote:
On Sat, Feb 9, 2013 at 4:56 AM, Matthew Flaschen <
mflaschen@wikimedia.org
>wrote:
> On 02/08/2013 08:35 PM, Paul Selitskas wrote: > > According to the manual, as there were no "pros" heard from
Design-l,
now > > the extension must undergo a technical design review, before
it
is
> decided > > whether the extension is able to fly on production sites -
deployment
> > review. > > Out of curiosity, where is this in the manual? > > Matt Flaschen > > <
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment
?
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
P.S. bikeshedding, guys... bikeshedding...
-- З павагай, Павел Селіцкас/Pavel Selitskas Wizardist @ Wikimedia projects _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Le 09/02/13 02:35, Paul Selitskas a écrit :
Hello.
I wrote an extension[1] for Wikinews and Wiktionary to replace the JS-driven custom tabs (Opinions in Wikinews, Citations/Template documentation in Wiktionary).
According to the manual, as there were no "pros" heard from Design-l, now the extension must undergo a technical design review, before it is decided whether the extension is able to fly on production sites - deployment review.
Hello Paul!
Thanks for notifying the new extension, we have so many nowadays that it is hard to keep track of all the code that flow in :-]
I will give it a poke on Monday, probably configure it on the beta cluster too for us to test it and play with.
Feel free to send patch over the weekend, I will be happy to review them too.
wikitech-l@lists.wikimedia.org