On my local Vagrant MediaWiki install (https://github.com/wikimedia/wmf-vagrant), I'm getting:
Running test BUG 1887, part 2: A <math> with a thumbnail- math enabled... No lock manager defined with the name `nullLockManager`.
when running the parser tests:
php tests/parserTests.php --file=extensions/Math/mathParserTests.txt
against master of the Math extension (MediaWiki is at git latest).
Can anyone shed some light on this? Is it expected this would work in production, meaning the test is broken?
Matt Flaschen
nullLockManager is defined in Setup.php.The code: LockManagerGroup::singleton()->get( 'nullLockManager' ); ... works fine in eval.php and is used in production.
-- View this message in context: http://wikimedia.7.n6.nabble.com/NullLockManager-and-the-math-extension-tp49... Sent from the Wikipedia Developers mailing list archive at Nabble.com.
On 02/06/2013 08:09 PM, Aaron Schulz wrote:
nullLockManager is defined in Setup.php.The code: LockManagerGroup::singleton()->get( 'nullLockManager' ); ... works fine in eval.php and is used in production.
However, $wgLockManagers is redefined in parserTest.inc .
It looks like it's basically the same as in a654a6e79adc8f4730bb69f79e0b6a960d7d3cbe (MW core) . Tim Starling added an explicit set to $wgLockManagers with only fsLockManager. It doesn't look like this was to block use of the null lock manager, but rather to specify the lockDirectory on the fs one.
Does it make sense to add null lock manager to parserTest.inc there as well?
The reason I'm asking is https://bugzilla.wikimedia.org/show_bug.cgi?id=43222 . https://gerrit.wikimedia.org/r/#/c/30177 changed the lock manager from null to fs.
But that wasn't part of the intent of the change. It was just to work around the test issue. If I can change parserTest.inc, I can put the default back to null.
Note that WMF uses:
'wmgMathFileBackend' => array( 'default' => 'global-multiwrite' ),
in production.
Thanks,
Matt Flaschen
Yes a654a6e79adc8f4730bb69f79e0b6a960d7d3cbe should be fixed. It should add the nullLockManager back.
-- View this message in context: http://wikimedia.7.n6.nabble.com/NullLockManager-and-the-math-extension-tp49... Sent from the Wikipedia Developers mailing list archive at Nabble.com.
On 02/08/2013 12:55 PM, Aaron Schulz wrote:
Yes a654a6e79adc8f4730bb69f79e0b6a960d7d3cbe should be fixed. It should add the nullLockManager back.
Done, please review.
https://gerrit.wikimedia.org/r/#/c/48144/
Thanks,
Matt Flaschen
wikitech-l@lists.wikimedia.org