I'm not sure if my opinion matters here, but I think FileDeleteForm.php is the appropriate place fro FileDeleteComplete hook. However, I think it'd be better if we had a way to move both FileUpload and future FileDelete hooks to a file under /includes rather than /filerepo

Hojjat (aka Huji)

On Fri, Feb 15, 2008 at 11:20 PM, Bryan Tong Minh bryan.tongminh@gmail.com wrote:

Hello,

I have a question about where file related hooks should be defined. Currently, the FileUpload hook is defined in filerepo/LocalFile.php and UploadCompleted is defined in SpecialUpload.php. Is there a reason for this?

I want to define new hooks FileDelete and FileDeletedCompleted. Should I follow the current practice and define them in filerepo/LocalFile.php and FileDeleteForm.php respectively?

Bryan

---

Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l