Ultimately, all extensions hosted on WMF git server will be integrated in Jenkins. If you get PHPUnit test, I will add a job for it as soon as the current jobs are stable enough.

Ultimately, all extensions hosted on WMF git server will be integrated in Jenkins. If you get PHPUnit test, I will add a job for it as soon as the current jobs are stable enough.

Hey, Ultimately, all extensions hosted on WMF git server will be integrated Thanks for your work on this! :)

On 29.08.2012, 18:27 Chad wrote: Ideally, core tests should include as many extension tests as possible to prevent core from silently breaking extensions.

Question: why does the config for non-extension tests attempt to load extensions? -Parser and -Misc both seem to be failing due to a broken inclusion of Wikibase.

Core tests should be run without any extensions.

1. is successfully runnig the test a requirement to successfully score on gerrit? (i.e. how is gerrit integrated)

2. does the extension need to include php unit?

On Thu, Aug 30, 2012 at 1:11 AM, Oren Bochman <orenbochman(a)gmail.com> wrote: Jenkins sets a Verified +1 or -1 on the change, depending on whether the tests succeed or not, just like for core. A V+1 is required to merge a change. So to merge any change into an extension, the tests (that is, the core tests and any extension tests) have to pass. But the extension isn't required to have tests, it's just that you can't submit changes that break the core tests or break any tests that are present in the extension. Existing extensions without any tests or awareness of phpunit will continue to work just fine, as long as they don't try to do crazy stuff that breaks a test in core. No, all of the phpunit wrapper stuff is in MediaWiki core. Adding tests to extensions is simple, see https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_f… . Roan _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l