I made them protected now, since an extension was extending the class.
-Aaron Schulz
Date: Fri, 4 Apr 2008 16:00:14 +0300
From: niklas.laxstrom(a)gmail.com
To: wikitech-l(a)lists.wikimedia.org
Subject: Re: [Wikitech-l] [MediaWiki-CVS] SVN:
[32765] trunk/phase3/includes/ChangesList.php
On 04/04/2008, aaron(a)svn.wikimedia.org <aaron(a)svn.wikimedia.org> wrote:
Modified: trunk/phase3/includes/ChangesList.php
- function arrow( $dir, $alt='' )
{
+ private function arrow( $dir, $alt='' ) {
- function sideArrow() {
+ private function sideArrow() {
- function downArrow() {
+ private function downArrow() {
- function spacerArrow() {
+ private function spacerArrow() {
Private? So much for backwards compatibility. Anyway now would be a
good time to think what to do to them.
1) Make them public or protected as they were?
2) Move them to a better place (GlobalFunctions? Xml?)
3) Should they be copied to extensions using them?
--
Niklas Laxström
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_________________________________________________________________
Get in touch in an instant. Get Windows Live Messenger now.