I found this in SpecialContributions.php (about line 72):
if ( 0 == $nCur && 0 == $nOld && 0 == $rcrows ) { $wgOut->addHTML( "\n<p>" . wfMsg( "nocontribs" ) . "</p>\n" ); return; }
What I'm missing is the $rcrows variable initialisation. Hopefully php init it with 0, but I'm not sure.
Possibly Lee or Brion have an idea :)
"Thomas Corell" said:
I found this in SpecialContributions.php (about line 72):
if ( 0 == $nCur && 0 == $nOld && 0 == $rcrows ) { $wgOut->addHTML( "\n<p>" . wfMsg( "nocontribs" ) . "</p>\n" ); return; }
What I'm missing is the $rcrows variable initialisation. Hopefully php init it with 0, but I'm not sure.
I don't know where or if $rcrows is initialized, but uninitialized variables in PHP 4 are set to NULL which == 0.
Mark Wojtowicz wrote:
"Thomas Corell" said:
I don't know where or if $rcrows is initialized, but uninitialized variables in PHP 4 are set to NULL which == 0.
Fine, I hoped it. I see I did not explain it clearly: 'grep -i rcrows' in the CVS only showed the mentioned line. I think the comparison is useless, but I'm not as fit as e.g. Lee with the code.
Thomas Corell wrote:
I found this in SpecialContributions.php (about line 72):
if ( 0 == $nCur && 0 == $nOld && 0 == $rcrows ) { $wgOut->addHTML( "\n<p>" . wfMsg( "nocontribs" ) . "</p>\n" ); return; }
What I'm missing is the $rcrows variable initialisation. Hopefully php init it with 0, but I'm not sure.
Possibly Lee or Brion have an idea :)
Looks like a chunk of code has been deleted. There's a comment which says:
# Sorting slowness on cur and especially old # forces us to check RC table first
But the code never touches RC.
-- Tim Starling
wikitech-l@lists.wikimedia.org