Dear all,
Over the past days I've been trying to get rid of the deprecated hook LanguageGetMagic in the repo[1]. I've updated about 60 extensions, I estimate, to use $magicWords imported through $wgExtensionMessagesFiles, instead of the hook.
As you may know, I'm not much of a developer, so when it gets harder, I throw the towel in the ring... There are three extensions that make a more esotheric use of LanguageGetMagic, that I'm not able to convert to use $magicWords. These are:
* FlaggedRevs/FlaggedRevs.setup.php: $wgHooks['LanguageGetMagic'][] = 'FlaggedRevsHooks::onLanguageGetMagic'; * LabeledSectionTransclusion/lst.php:$wgHooks['LanguageGetMagic'][] = 'LabeledSectionTransclusion::setupMagic'; * MetavidWiki/includes/MV_GlobalFunctions.php:$wgHooks['LanguageGetMagic'][] = 'mvMagicParserFunction_Magic';
If you can help out here, please do so. It would be much appreciated.
Next, in my opinion, would be to start throwing warnings using wfDeprecated on use of the hook LanguageGetMagic, but I haven't really been able to find where that could be done for a hook. If you can be of help there, please let me know. There may also be some other deprecated hooks that could get more attention if they would throw warnings on use.
[1] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/languagegetmagic
Cheers!
Siebrand
I'll take of of those last 3 usages.
On Thu, Jan 19, 2012 at 9:12 AM, Siebrand Mazeland s.mazeland@xs4all.nlwrote:
Dear all,
Over the past days I've been trying to get rid of the deprecated hook LanguageGetMagic in the repo[1]. I've updated about 60 extensions, I estimate, to use $magicWords imported through $wgExtensionMessagesFiles, instead of the hook.
As you may know, I'm not much of a developer, so when it gets harder, I throw the towel in the ring... There are three extensions that make a more esotheric use of LanguageGetMagic, that I'm not able to convert to use $magicWords. These are:
- FlaggedRevs/FlaggedRevs.setup.php:
$wgHooks['LanguageGetMagic'][] = 'FlaggedRevsHooks::onLanguageGetMagic';
- LabeledSectionTransclusion/lst.php:$wgHooks['LanguageGetMagic'][] =
'LabeledSectionTransclusion::setupMagic';
MetavidWiki/includes/MV_GlobalFunctions.php:$wgHooks['LanguageGetMagic'][] = 'mvMagicParserFunction_Magic';
If you can help out here, please do so. It would be much appreciated.
Next, in my opinion, would be to start throwing warnings using wfDeprecated on use of the hook LanguageGetMagic, but I haven't really been able to find where that could be done for a hook. If you can be of help there, please let me know. There may also be some other deprecated hooks that could get more attention if they would throw warnings on use.
[1] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/languagegetmagic
Cheers!
Siebrand
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
FlaggedRevs and MetavidWiki done https://www.mediawiki.org/wiki/Special:Code/MediaWiki/109571
For LST there's already hardcoded translations and I'm not sure how to do those. Is it right to include the english ones in the translations?
On Thu, Jan 19, 2012 at 9:43 AM, John Du Hart compwhizii@gmail.com wrote:
I'll take of of those last 3 usages.
On Thu, Jan 19, 2012 at 9:12 AM, Siebrand Mazeland s.mazeland@xs4all.nlwrote:
Dear all,
Over the past days I've been trying to get rid of the deprecated hook LanguageGetMagic in the repo[1]. I've updated about 60 extensions, I estimate, to use $magicWords imported through $wgExtensionMessagesFiles, instead of the hook.
As you may know, I'm not much of a developer, so when it gets harder, I throw the towel in the ring... There are three extensions that make a more esotheric use of LanguageGetMagic, that I'm not able to convert to use $magicWords. These are:
- FlaggedRevs/FlaggedRevs.setup.php:
$wgHooks['LanguageGetMagic'][] = 'FlaggedRevsHooks::onLanguageGetMagic';
- LabeledSectionTransclusion/lst.php:$wgHooks['LanguageGetMagic'][] =
'LabeledSectionTransclusion::setupMagic';
MetavidWiki/includes/MV_GlobalFunctions.php:$wgHooks['LanguageGetMagic'][] = 'mvMagicParserFunction_Magic';
If you can help out here, please do so. It would be much appreciated.
Next, in my opinion, would be to start throwing warnings using wfDeprecated on use of the hook LanguageGetMagic, but I haven't really been able to find where that could be done for a hook. If you can be of help there, please let me know. There may also be some other deprecated hooks that could get more attention if they would throw warnings on use.
[1] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/languagegetmagic
Cheers!
Siebrand
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
-- John
Op 19 jan. 2012 om 22:30 heeft John Du Hart compwhizii@gmail.com het volgende geschreven:
FlaggedRevs and MetavidWiki done https://www.mediawiki.org/wiki/Special:Code/MediaWiki/109571
Thanks a lot, John!
For LST there's already hardcoded translations and I'm not sure how to do those. Is it right to include the english ones in the translations?
That is not needed. The English aliases or whatever you want to call them are added for any content language when using $magicWords.
Siebrand
wikitech-l@lists.wikimedia.org