Michael Dale, Tim Starling and I have been planning the integration of the things being done of the js2-work branch into phase3. Michael and I today discussed some of the changes we are looking to make, and we wanted to make contact with stakeholders about them.
* Create a new folder: "phase3/static/" * Move "js2-work/js/" to "phase3/static/js". * Move the PHP portions of the 'js2-work/js/mwEmbed/" resources to their appropriate MediaWiki locations such as "phase3/includes/scriptloader/" and "phase3/maintenance" * Move JavaScript files in "phase3/skins/common/" into "phase3/static/js/" * Move CSS files in "phase3/skins/common/" into "phase3/static/css/" * Move image files in "phase3/skins/common/" into "phase3/static/images/"
The resulting structure will look like...
* phase3/static/ * css/ -- Gerenally shared CSS files * images/ -- Generally shared image files * js/ -- MediaWiki Core JavaScript files, jQuery, jQuery UI, additional JavaScript modules (Purely JavaScript extensions), ScriptLoader support code
Overall, we're just moving things where we see they should be. Justifications for moving the skins/common/* stuff to their own places is basically that "skins/common/" is a strange place for resources which are used mostly by non-skin software and it fits more with the current bits.wikimedia.org approach.
Please try and keep responses concise, productive and on-topic. (i.e discussions about how wikibts will change can be left for another thread)
- Trevor
Trevor Parscal wrote:
Michael Dale, Tim Starling and I have been planning the integration of the things being done of the js2-work branch into phase3. Michael and I today discussed some of the changes we are looking to make, and we wanted to make contact with stakeholders about them.
* Create a new folder: "phase3/static/" * Move "js2-work/js/" to "phase3/static/js". * Move the PHP portions of the 'js2-work/js/mwEmbed/" resources to their appropriate MediaWiki locations such as "phase3/includes/scriptloader/" and "phase3/maintenance" * Move JavaScript files in "phase3/skins/common/" into "phase3/static/js/" * Move CSS files in "phase3/skins/common/" into "phase3/static/css/" * Move image files in "phase3/skins/common/" into "phase3/static/images/"
Most of the js2-work branch should never have been in the core and should not go into the core now. The bulk of it should go to one or more extensions.
At some point, I will review the current state of the script loader in js2-work, but as I implied in my previous message, that time is not now. There are several shorter review projects which we need to get through first.
The js2-work branch is too big to merge in one go, because there is so much work to do on every component.
What you said to me in our phone meeting is that you want performance enhancements for Usability/Vector as a top priority, so that's what I'm planning to do. Bundling up that change with 10k lines of Michael's code is not going to get those performance enhancements live any faster.
-- Tim Starling
On Mon, Feb 22, 2010 at 6:55 PM, Trevor Parscal tparscal@wikimedia.org wrote:
The resulting structure will look like...
* phase3/static/ * css/ -- Gerenally shared CSS files * images/ -- Generally shared image files * js/ -- MediaWiki Core JavaScript files, jQuery, jQuery UI, additional JavaScript modules (Purely JavaScript extensions), ScriptLoader support code
Overall, we're just moving things where we see they should be. Justifications for moving the skins/common/* stuff to their own places is basically that "skins/common/" is a strange place for resources which are used mostly by non-skin software and it fits more with the current bits.wikimedia.org approach.
This sounds sensible to me. We should keep stuff that needs to be web-accessible (entry points, static files) in separate directories from stuff that doesn't (like skin PHP files).
wikitech-l@lists.wikimedia.org