Hello everyone,
I am happy to announce the final release candidate for MediaWiki 1.24.0. Download links are given at the end of this email. There won't be any more RC candidates before a final release on Wednesday unless someone finds a really critical error.
== Changes since 1.24.0-rc.2 == * The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
Public keys: https://www.mediawiki.org/keys/keys.html
********************************************************************** 1.24.0-rc.3 ********************************************************************** Download: http://releases.wikimedia.org/mediawiki/1.24/mediawiki-core-1.24.0-rc.3.tar.... http://releases.wikimedia.org/mediawiki/1.24/mediawiki-1.24.0-rc.3.tar.gz
GPG signatures: http://releases.wikimedia.org/mediawiki/1.24/mediawiki-core-1.24.0-rc.3.tar.... http://releases.wikimedia.org/mediawiki/1.24/mediawiki-1.24.0-rc.3.tar.gz.si...
Mark A. Hershberger (Wiki Release Team)
On 11/24/14 7:13 PM, Mark A. Hershberger wrote:
== Changes since 1.24.0-rc.2 ==
- The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
Is there an associated bug report? We decided to revert a similar move in core and this goes against the consensus in code review and the wikitech discussions that were held months ago (back in May!), so I strongly recommend reverting this.
First off, this "change"[1] was done outside of git meaning there was no opportunity for code review and no possibility of a revert.
Adding a composer.json to MediaWiki has been intentionally done (see Ori's extremely long rationale on [2]) so MediaWiki can properly depend on external libraries like phpunit, and a bunch more starting with the 1.25 development cycle.
This has been previously discussed on this list (see [3] and [4]) explaining why we chose to have a composer.json in core. Maybe we need better release notes documenting this switch since 1.23.
I'm frustrated at why this is coming in at the last minute and done in a seemingly secret manner especially after there have been so many discussions about this that the "release team" themselves were involved in.
-- Legoktm
[1] https://gerrit.wikimedia.org/r/#/c/175453/ [2] https://gerrit.wikimedia.org/r/#/c/132788/ [3] https://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg76217.html [4] https://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg76250.html
On 2014-11-24 8:47 PM, Legoktm wrote:
On 11/24/14 7:13 PM, Mark A. Hershberger wrote:
== Changes since 1.24.0-rc.2 ==
- The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
Is there an associated bug report? We decided to revert a similar move in core and this goes against the consensus in code review and the wikitech discussions that were held months ago (back in May!), so I strongly recommend reverting this.
First off, this "change"[1] was done outside of git meaning there was no opportunity for code review and no possibility of a revert.
Adding a composer.json to MediaWiki has been intentionally done (see Ori's extremely long rationale on [2]) so MediaWiki can properly depend on external libraries like phpunit, and a bunch more starting with the 1.25 development cycle.
This has been previously discussed on this list (see [3] and [4]) explaining why we chose to have a composer.json in core. Maybe we need better release notes documenting this switch since 1.23.
I'm frustrated at why this is coming in at the last minute and done in a seemingly secret manner especially after there have been so many discussions about this that the "release team" themselves were involved in.
This probably shouldn't be a problem. The real reason we want a composer.json is for git, to include 3rd party libraries in core.
These libraries are bundled into the tarball so that tarball users don't need to `composer install` to get MediaWiki working, especially when some of them don't even have a CLI.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/]
On 11/24/2014 11:47 PM, Legoktm wrote:
On 11/24/14 7:13 PM, Mark A. Hershberger wrote:
== Changes since 1.24.0-rc.2 ==
- The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
Is there an associated bug report? We decided to revert a similar move in core and this goes against the consensus in code review and the wikitech discussions that were held months ago (back in May!), so I strongly recommend reverting this.
First off, this "change"[1] was done outside of git meaning there was no opportunity for code review and no possibility of a revert.
This brings up a question. Where is the code that builds the tarball?
Matt Flaschen
Matthew Flaschen mflaschen@wikimedia.org writes:
This brings up a question. Where is the code that builds the tarball?
The script is make-release/make-release.py in the mediawiki/tools/release[1] repository.
I've updated the Release checklist[2] with this information.
Mark.
Footnotes: [1] http://git.wikimedia.org/tree/mediawiki%2Ftools%2Frelease.git
[2] https://www.mediawiki.org/wiki/Release_checklist
On 11/26/2014 08:57 AM, Mark A. Hershberger wrote:
Matthew Flaschen mflaschen@wikimedia.org writes:
This brings up a question. Where is the code that builds the tarball?
The script is make-release/make-release.py in the mediawiki/tools/release[1] repository.
Thanks for the info.
Matt Flaschen
Le 25/11/2014 04:13, Mark A. Hershberger a écrit :
I am happy to announce the final release candidate for MediaWiki 1.24.0. Download links are given at the end of this email. There won't be any more RC candidates before a final release on Wednesday unless someone finds a really critical error.
Can you please push the tag 1.24.0-rc.3 ?
Thanks!
On 25 November 2014 at 04:13, Mark A. Hershberger mah@nichework.com wrote:
I am happy to announce the final release candidate for MediaWiki 1.24.0. Download links are given at the end of this email. There won't be any more RC candidates before a final release on Wednesday unless someone finds a really critical error.
== Changes since 1.24.0-rc.2 ==
- The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
I have to agree with Legoktm.
Quote from https://www.mediawiki.org/wiki/Manual:Upgrading#Using_a_tarball_package: "You should put the decompressed tarball in a new and empty folder on your server. If you instead extract the new version directly on top of your old version, rather than in a new directory, you should follow #Back up existing files and the database: otherwise, if you've made any customizations you may erase them in a way that leaves you with no reference to re-apply them from."
Also, this will complicate installation instructions for every extension and skin that uses composer. They will now have to distinguish between two possible baselines which is a hassle for developers but more importantly a source of confusion for users.
Stephan
Hi,
== Changes since 1.24.0-rc.2 ==
- The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
I had the same issue not aware that MW has replaced my existing composer.json and by the time I realized it was already to late (doing a `composer update` which costs me some considerable development effort).
Despite this, I think we should stick to the `composer.json` and for users that already have a `composer.json` in place make sure that they migrate the content so that they don't loose any package by simply replacing the file.
In future, if changes are required to the `composer.json`, please merge instead of a simple replace and keep the user free from pain.
Cheers
On 11/26/14, Stephan Gambke s7eph4n@gmail.com wrote:
On 25 November 2014 at 04:13, Mark A. Hershberger mah@nichework.com wrote:
I am happy to announce the final release candidate for MediaWiki 1.24.0. Download links are given at the end of this email. There won't be any more RC candidates before a final release on Wednesday unless someone finds a really critical error.
== Changes since 1.24.0-rc.2 ==
- The composer.json file has been renamed to composer.json.sample after Jamie Thingelstad reported that his composer.json was overwritten by the tarball.
I have to agree with Legoktm.
Quote from https://www.mediawiki.org/wiki/Manual:Upgrading#Using_a_tarball_package: "You should put the decompressed tarball in a new and empty folder on your server. If you instead extract the new version directly on top of your old version, rather than in a new directory, you should follow #Back up existing files and the database: otherwise, if you've made any customizations you may erase them in a way that leaves you with no reference to re-apply them from."
Also, this will complicate installation instructions for every extension and skin that uses composer. They will now have to distinguish between two possible baselines which is a hassle for developers but more importantly a source of confusion for users.
Stephan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Based on the feedback, it seems obvious that we will have to go with the previous RC for the release.
Legoktm: You're right when you ask "where is the bug for this?" The feedback and interaction happened mostly on Twitter and Skype. I should have asked Jamie to file a bug.
More below.
James HK jamesin.hongkong.1@gmail.com writes:
Despite this, I think we should stick to the `composer.json` and for users that already have a `composer.json` in place make sure that they migrate the content so that they don't loose any package by simply replacing the file.
In order to avoid causing too much confusion for those users who have already used composer to install the latest Semantic MediaWiki, we'll have to put an obvious notice in the announcement.
In future, if changes are required to the `composer.json`, please merge instead of a simple replace and keep the user free from pain.
Are you willing to help modify the installer to help with this?
Mark.
wikitech-l@lists.wikimedia.org