I am mildly surprised by Jenkins giving a +1 Code Review (not Verification) here.
https://gerrit.wikimedia.org/r/#/c/33505/
Just wondering if there is maybe a setup issue.
Cheers, Denny
2013/1/9 Denny Vrandečić denny.vrandecic@wikimedia.de:
I am mildly surprised by Jenkins giving a +1 Code Review (not Verification) here.
https://gerrit.wikimedia.org/r/#/c/33505/
Just wondering if there is maybe a setup issue.
Note that was on December 17. I don't remember the exact dates, but for a short time during the transition from "Jenkins runs unit tests on every submission" to "Jenkins runs only lint tests for submissions from untrusted people" it was configured to give CR+1 for linting and V+1 for unit tests.
Ah, thanks, that explains it.
2013/1/9 Brad Jorsch bjorsch@wikimedia.org
2013/1/9 Denny Vrandečić denny.vrandecic@wikimedia.de:
I am mildly surprised by Jenkins giving a +1 Code Review (not
Verification)
here.
https://gerrit.wikimedia.org/r/#/c/33505/
Just wondering if there is maybe a setup issue.
Note that was on December 17. I don't remember the exact dates, but for a short time during the transition from "Jenkins runs unit tests on every submission" to "Jenkins runs only lint tests for submissions from untrusted people" it was configured to give CR+1 for linting and V+1 for unit tests.
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org