Brion Vibber wrote:
Modified Files: Tag: REL1_3 Article.php Log Message: Reverting last patch which causes "Fatal error: Call to a member function on a non-object" on old page views. Please test patches prior to check-in.
Sorry, Brion. Yes, I know I should test it, but running REL1_3 would require me to create a whole new DB and everything.
The error was just that I forgot a "global $wgUser;". 'Tis all ...
Timwi
Timwi wrote:
Brion Vibber wrote:
Modified Files: Tag: REL1_3 Article.php Log Message: Reverting last patch which causes "Fatal error: Call to a member function on a non-object" on old page views. Please test patches prior to check-in.
Sorry, Brion. Yes, I know I should test it, but running REL1_3 would require me to create a whole new DB and everything.
The error was just that I forgot a "global $wgUser;". 'Tis all ...
Please, please, *please* DO NOT commit anything to the STABLE BRANCH THAT WE RUN OUR LIVE SITES ON without testing it. If someone were silly enough to, say, update the live sites from the stable branch to install a bug fix, suddenly *bam* everything would break.
Creating another database to test with is 30 seconds' work. If you're not willing to put that time in, please don't commit to the stable branch.
Sorry for the shouting.
-- brion vibber (brion @ pobox.com)
wikitech-l@lists.wikimedia.org