Simetrical schrieb:

On Thu, Jun 19, 2008 at 6:07 AM, raymond-Y8jq7F6rJ48dvk2hry9Ukdi2O/JbrIOy@public.gmane.org wrote:

...

Log Message:

• Per Nikerabbits suggestion: Move vertical-align into CSS
• Move text-align into CSS too.

Modified Paths:

trunk/phase3/includes/DefaultSettings.php trunk/phase3/includes/specials/Preferences.php trunk/phase3/skins/modern/main.css trunk/phase3/skins/modern/rtl.css trunk/phase3/skins/monobook/main.css trunk/phase3/skins/monobook/rtl.css trunk/phase3/skins/simple/main.css trunk/phase3/skins/simple/rtl.css

Surely this should just change shared.css. This appears to be a regression for non-Monobook-based skins (e.g., Cologne Blue), and is also overly verbose (changes unnecessarily many files).

Hmm ok, Brion reverted it with r36485:

Revert r36446, 36447 -- spews a whole bunch of table alignment into various skins' skin-specific CSS. This seems a bit odd; if there's a reason for it *at all* it should be in the shared CSS, but I don't see any reason for it to begin with, really.

Two questions:

1. If there is no reason for vertical-top than we should close bug 14590 as WONTFIX

2. I am missing a real common /skins/common/rtl.css. We have /skins/common/common_rtl.css but it seems to be not valid for Monobook/Modern/Simple:

/* * This file contains CSS settings common to RTL wikis use the old * pre-Monobook skins Wikistandard, Nostalgia and CologneBlue */

I am little bit confused...

Raymond.