Hey,
Most of my extensions have been migrated to the new git setup with gerrit. I'm not happy with the workflow for the extensions where I'm basically the only real contributor or those where no one is going to review my stuff anyway. Although I can approve my own changes and merge them in, this is rather silly. Is there a way to disable the review step for certain extensions (ie post comit review instead of gated trunk), and is it possible to automatically merge in commits of certain users? For example in case of Semantic MediaWiki, I'd like my commits and those of the other core SMW devs to be merged in without first needing a review, while commits of random other people should require review first.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --
Le 08/04/12 20:27, Jeroen De Dauw a écrit :
Most of my extensions have been migrated to the new git setup with gerrit. I'm not happy with the workflow for the extensions where I'm basically the only real contributor or those where no one is going to review my stuff anyway. Although I can approve my own changes and merge them in, this is rather silly. Is there a way to disable the review step for certain extensions (ie post comit review instead of gated trunk), and is it possible to automatically merge in commits of certain users? For example in case of Semantic MediaWiki, I'd like my commits and those of the other core SMW devs to be merged in without first needing a review, while commits of random other people should require review first.
Hello Jeroen
To create a change in Gerrit, one has to push a reference to a specific path starting by: refs/for/. To enforce the use of Gerrit we have it disallow any push out of refs/for :-D
We can allow people to push directly in the repository without having Gerrit to "intercept" the commit. We can even make a group of people allowed to push without review, another one allowed to tag release and another group which can only push to refs/for/*.
I am not sure what is the process to requests access changes, Sumanah could tell about it. Meanwhile, you can ask ^demon about it.
cheers,
On 04/08/2012 03:40 PM, Antoine Musso wrote:
Le 08/04/12 20:27, Jeroen De Dauw a écrit :
Most of my extensions have been migrated to the new git setup with gerrit. I'm not happy with the workflow for the extensions where I'm basically the only real contributor or those where no one is going to review my stuff anyway. Although I can approve my own changes and merge them in, this is rather silly. Is there a way to disable the review step for certain extensions (ie post comit review instead of gated trunk), and is it possible to automatically merge in commits of certain users? For example in case of Semantic MediaWiki, I'd like my commits and those of the other core SMW devs to be merged in without first needing a review, while commits of random other people should require review first.
Hello Jeroen
To create a change in Gerrit, one has to push a reference to a specific path starting by: refs/for/. To enforce the use of Gerrit we have it disallow any push out of refs/for :-D
We can allow people to push directly in the repository without having Gerrit to "intercept" the commit. We can even make a group of people allowed to push without review, another one allowed to tag release and another group which can only push to refs/for/*.
I am not sure what is the process to requests access changes, Sumanah could tell about it. Meanwhile, you can ask ^demon about it.
cheers,
Jeroen, if the other core SMW devs put their names down at https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership then we'll process them within a couple of days, so they can have the ability to merge commits into the SMW extensions (and veto/abandon commits as well).
I will defer to Chad, Antoine, and Ryan regarding "automatically +2 and merge only these committers' merge requests" configuration.
Hey,
We can allow people to push directly in the repository without having
Gerrit to "intercept" the commit.
Right, I looked a bit through gerrits docs and figured I actually have the rights for my extensions to enable myself to do this, using this stuff:
https://review.typo3.org/Documentation/access-control.html#category_push_mer...
Might be good to document this somewhere, assuming this is the correct approach :)
if the other core SMW devs put their names down at
https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership then we'll process them within a couple of days
Luckily this is not needed. I'd like to point out that any situation where people managing a project don't have such access and would need to rely on people from outside their community to get things done is bad and might very well incentivise them to not use WMFs gerrit.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --
wikitech-l@lists.wikimedia.org