simetrical@svn.wikimedia.org wrote:
(bug 6873) When viewing old revisions, add link to diff to current version.
[snip]
-'old-revision-navigation' => 'Revision as of $1; $5<br />($6) $3 | $2 | $4 ($7)', +'old-revision-navigation' => 'Revision as of $1; $5<br />($6) $3 | $2 ($8) | $4 ($7)',
A note: changing the existing message this way means that customized versions will not show the new functionality.
If it's important to add, it may be more appropriate to rename the message.
Actually this message should probably be broken up anyway; it seems badly factored to me, mixing a line of text and what should probably be a programmatic line of links into a single HTML message.
-- brion vibber (brion @ pobox.com)
Brion Vibber wrote:
simetrical@svn.wikimedia.org wrote:
-'old-revision-navigation' => 'Revision as of $1; $5<br />($6) $3 | $2 | $4 ($7)', +'old-revision-navigation' => 'Revision as of $1; $5<br />($6) $3 | $2 ($8) | $4 ($7)',
A note: changing the existing message this way means that customized versions will not show the new functionality.
If it's important to add, it may be more appropriate to rename the message.
As a historical note, that particular message has gone through three or four such name changes (some only changing punctuation) already, as new parameters have been added. One can probably get a fairly good idea of its evolution by observing the strange order of the numbered parameters.
Actually this message should probably be broken up anyway; it seems badly factored to me, mixing a line of text and what should probably be a programmatic line of links into a single HTML message.
I tried that back when I added the diff links ($6 and $7), but someone (can't remember who any more) complained that the punctuation should be customizable for different languages. Thus the current implementation.
Perhaps my mistake was in including the "; $5" part in the programmatic section; leaving that customizable but generating the line break and everything after it programmatically might be an acceptable compromise.
On 11/20/06, Ilmari Karonen nospam@vyznev.net wrote:
Brion Vibber wrote:
simetrical@svn.wikimedia.org wrote:
-'old-revision-navigation' => 'Revision as of $1; $5<br />($6) $3 | $2 | $4 ($7)', +'old-revision-navigation' => 'Revision as of $1; $5<br />($6) $3 | $2 ($8) | $4 ($7)',
A note: changing the existing message this way means that customized versions will not show the new functionality.
If it's important to add, it may be more appropriate to rename the message.
As a historical note, that particular message has gone through three or four such name changes (some only changing punctuation) already, as new parameters have been added. One can probably get a fairly good idea of its evolution by observing the strange order of the numbered parameters.
Actually this message should probably be broken up anyway; it seems badly factored to me, mixing a line of text and what should probably be a programmatic line of links into a single HTML message.
I tried that back when I added the diff links ($6 and $7), but someone (can't remember who any more) complained that the punctuation should be customizable for different languages. Thus the current implementation.
Perhaps my mistake was in including the "; $5" part in the programmatic section; leaving that customizable but generating the line break and everything after it programmatically might be an acceptable compromise.
I ended up splitting it into two: one "Revision as of $1 by $2", one "($1) $2 | $3 ($4) | $5 ($6)". There's no <br>, they're just each wrapped in a div software-side. I don't think it's really reasonable to break them up further; I guess you could split the latter message into three, but then you'd have to insert the two pipes one way or another, and I don't see a whole lot of mileage in it.
wikitech-l@lists.wikimedia.org