Magnus Manske wrote:

As we are now progressing towards XML generation, what to do with it? I altered a little code from the PHP page about the XML parser to arrange the XML in a treelike structure. Don't know where to put it, so I'll just dump it below ;-)

Using the eval function makes it a bit hard to understand and I suspect it isn't very efficient. How about the following:

<?

// the base class for an element class element { var $name = ""; var $attrs = array(); var $children = array();

function myPrint() { echo "<UL>"; echo "<LI> <B> Name: </B> $this->name"; // print attributes echo "<LI> <B> Attributes: </B>"; foreach ($this->attrs as $name => $value) { echo "$name => $value; " ; } // print children foreach ($this->children as $child) { if ( is_string($child) ) { echo "<LI> $child"; } else { $child->myPrint(); } } echo "</UL>"; }

}

$ancStack = array(); // the stack with ancestral elements $allElem = array(); // the stack with all elements in the tree

// Three global functions needed for parsing, sorry guys function wgXMLstartElement($parser, $name, $attrs) { global $ancStack, $allElem;

$newElem = new element; $newElem->name = $name; $newElem->attrs = $attrs; array_push($allElem, $newElem); $newIndex = count($allElem)-1; // add to parent if parent exists if ( $ancStack ) { array_push($ancStack[count($ancStack)-1]->children, &$allElem[$newIndex]); } // push new element itself on ancestor stack array_push($ancStack, &$allElem[$newIndex]); }

function wgXMLendElement($parser, $name) { global $ancStack;

// pop element of stack array_pop($ancStack); }

function wgXMLcharacterData($parser, $data) { global $ancStack; // add to parent if parent exists if ( $ancStack ) { array_push($ancStack[count($ancStack)-1]->children, $data); } }

# Here's the class that generates a nice tree class xml2php {

function &scanFile( $filename ) { global $allElem;

$xml_parser = xml_parser_create(); xml_set_element_handler($xml_parser, "wgXMLstartElement", "wgXMLendElement"); xml_set_character_data_handler($xml_parser, "wgXMLcharacterData"); if (!($fp = fopen($filename, "r"))) { die("could not open XML input"); } while ($data = fread($fp, 4096)) { if (!xml_parse($xml_parser, $data, feof($fp))) { die(sprintf("XML error: %s at line %d", xml_error_string(xml_get_error_code($xml_parser)), xml_get_current_line_number($xml_parser))); } } xml_parser_free($xml_parser);

return $allElem[0]; }

}

$w = new xml2php; $filename = 'sample.xml'; $result = $w->scanFile( $filename ); $result->myPrint();

return 0;

?>

Magnus Manske wrote:

// If var already defined, make array eval('$test=isset('.$wgXMLobject->tree.'->'.$name.');');

In case you didn't know, you _can_ write code like this:

$test = isset( ${$wgXMLobject->tree}->$name );

While it's amazingly ugly and probably a bad idea anyway;) it's going to be more efficient than the even uglier use of an eval() that has to parse and compile entire PHP statements at runtime. (For the above case, about three times faster.)

-- brion vibber (brion @ pobox.com)