Hello,
I will be *upgrading Gerrit* from the 3.8 series to the 3.9 series. I have scheduled the upgrade for *Monday June 3rd at 8am UTC*. It is immediately after the UTC morning backport & config window.
The upgrade requires the Gerrit service to be stopped for the duration of the upgrade. Given we do not need to reindex all the changes, the downtime should be just a few minutes.
Gerrit 3.9 brings:
* Support for diff3 rendering for changes having conflict markers (T359821 https://phabricator.wikimedia.org/T359821) which corresponds to cgit merge.conflictStyle=diff3. * User Suggested Edits http://gerrit-documentation.storage.googleapis.com/Documentation/3.9.5/user-suggest-edits.html, an easy way for reviewers to suggest code changes which can be easily applied by the change owner. One can imagine CI would be able to offers suggestions as well (such as phpcb from PHP CodeSniffer or eslint?). * Gerrit would now use "Revert^2" syntax when crafting a revert instead of chaining them as "Revert "Revert "Revert...". * And more UI changes https://www.gerritcodereview.com/3.9.html#gerrit-ui-changes
The release notes: https://www.gerritcodereview.com/3.9.html https://www.gerritcodereview.com/3.9.htmlThe upgrade task: https://phabricator.wikimedia.org/T354887 Deployment calendar entry https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20240603T0800
Antoine "hashar" Musso Wikimedia Release Engineering
I'm really looking forward to User Suggested Edits https://gerrit-documentation.storage.googleapis.com/Documentation/3.9.5/user-suggest-edits.html! Thanks!
On Wed, May 29, 2024 at 8:14 AM Antoine Musso hashar@free.fr wrote:
Hello,
I will be *upgrading Gerrit* from the 3.8 series to the 3.9 series. I have scheduled the upgrade for *Monday June 3rd at 8am UTC*. It is immediately after the UTC morning backport & config window.
The upgrade requires the Gerrit service to be stopped for the duration of the upgrade. Given we do not need to reindex all the changes, the downtime should be just a few minutes.
Gerrit 3.9 brings:
- Support for diff3 rendering for changes having conflict markers (
T359821 https://phabricator.wikimedia.org/T359821) which corresponds to cgit merge.conflictStyle=diff3.
- User Suggested Edits
http://gerrit-documentation.storage.googleapis.com/Documentation/3.9.5/user-suggest-edits.html, an easy way for reviewers to suggest code changes which can be easily applied by the change owner. One can imagine CI would be able to offers suggestions as well (such as phpcb from PHP CodeSniffer or eslint?).
- Gerrit would now use "Revert^2" syntax when crafting a revert
instead of chaining them as "Revert "Revert "Revert...".
- And more UI changes
https://www.gerritcodereview.com/3.9.html#gerrit-ui-changes
The release notes: https://www.gerritcodereview.com/3.9.html The upgrade task: https://phabricator.wikimedia.org/T354887 Deployment calendar entry https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20240603T0800
Antoine "hashar" Musso Wikimedia Release Engineering _______________________________________________ Ops mailing list -- ops@lists.wikimedia.org To unsubscribe send an email to ops-leave@lists.wikimedia.org
On Wed, May 29, 2024 at 3:14 PM Antoine Musso hashar@free.fr wrote:
User Suggested Edits http://gerrit-documentation.storage.googleapis.com/Documentation/3.9.5/user-suggest-edits.html, an easy way for reviewers to suggest code changes which can be easily applied by the change owner. One can imagine CI would be able to offers suggestions as well (such as phpcb from PHP CodeSniffer or eslint?).
For CI it was already possible via the (now removed) robot comment feature, but this seems quite a bit simpler. Thanks for your work on the Gerrit upgrades!
Le 29/05/2024 à 15:13, Antoine Musso a écrit :
Hello,
I will be *upgrading Gerrit* from the 3.8 series to the 3.9 series. I have scheduled the upgrade for *Monday June 3rd at 8am UTC*. It is immediately after the UTC morning backport & config window.
Hello,
I have ended up cancelling the upgrade since the bundled Gerrit 3.9 provided by upstream requires Java 17 and our servers run Java 11. I guess I will look at upgrading Java first and reschedule the Gerrit upgrade once done.
Antoine "hashar" Musso
wikitech-l@lists.wikimedia.org