I'm referring to the Foo.deps.php files which contain:
// This file exists to ensure that base classes are preloaded before // <filename> is compiled, working around a bug in the APC opcode // cache on PHP 5, where cached code can break if the include order // changed on a subsequent page view. // see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
The referenced bug http://pecl.php.net/bugs/bug.php?id=6503 is marked as fixed in PHP 5.1.x. Can we remove those file or is there something else going on with this problem that we should be aware of?
-Niklas
On 05/11/10 00:17, Niklas Laxström wrote:
I'm referring to the Foo.deps.php files which contain:
// This file exists to ensure that base classes are preloaded before // <filename> is compiled, working around a bug in the APC opcode // cache on PHP 5, where cached code can break if the include order // changed on a subsequent page view. // see http://lists.wikimedia.org/pipermail/wikitech-l/2006-January/021311.html
The referenced bug http://pecl.php.net/bugs/bug.php?id=6503 is marked as fixed in PHP 5.1.x. Can we remove those file or is there something else going on with this problem that we should be aware of?
The bug fix was to treat a class declaration with the wrong kind of binding as a cache miss. So it could potentially damage performance to remove the .deps files.
-- Tim Starling
wikitech-l@lists.wikimedia.org