Hey,
I've been looking for an alternative to Gerrit's code review interface and came across Mylyn, a plug-in for Eclipse with a connector for Gerrit. I'm happy to report that it does work well with our Gerrit setup. Now you can choose between two UX disasters :)
I'm not a fan of Eclipse, but it is fairly customizable, so if you have accessibility needs or would simply prefer to have a different layout for diffs, there's a chance you'll be able to beat out a better user experience out of Eclipse. Using Eclipse also makes it possible to do code reviews off-line and sync them later.
Screenshot: http://www.mediawiki.org/wiki/File:Gerrit-review-in-Eclipse.png
I started to document the configuration process over at [[mw:Git/Workflow]]:
http://www.mediawiki.org/wiki/Git/Workflow#How_to_comment_on.2C_review.2C_an...
I hope this is useful.
-- Ori Livneh ori@wikimedia.org
On 10/30/2012 08:03 PM, Ori Livneh wrote:
I've been looking for an alternative to Gerrit's code review interface
Gerrit, for all its problems, does not require the reviewing developer to install extra software and Eclipse is quite a bit of software if the developer isn't already using it.
I would suggest that any alternative workflows work on top of and integrate with Gerrit, or if we're all in agreement that we should ditch Gerrit for code review, that the requirements to use them not be so heavyweight as "first, install Eclipse..."
That said, if there is a way to use Mylyn without Eclipse, or if there is a way to integrate Mylyn with Gerrit, then I'd be in favor.
Gerrit, I think, at least provides us with a central place to keep the reviews.
It looks like there is Gerrit integration for Mylyn http://www.eclipse.org/reviews/gerrit/ so if you like Mylyn it looks like you are free to use it while still working with people who are still using Gerrit.
Mark.
It's relatively easy to review (assess) the changes locally. I should look for the command to add reviewers and read/write comments. There's probably an API for that.
wikitech-l@lists.wikimedia.org