On 15 September 2013 22:01, Brion Vibber <bvibber(a)wikimedia.org> wrote:
I believe it's not subversion itself as much as
the user-interface of
TortoiseSVN, which lots of people have found easy to use and powerful.
git-review kind of forces you to use the command-line interface to git,
which also tends to be slightly more complicated on Windows than on Linux
because you're kind of smashing together a Unix-like environment and a
Windows-like environment.
Those are indeed basically the two reasons I'm looking into this. On linux,
the git-review workflow is relatively smooth, but on windows it's so much
harder because the console is clunky, and the GUI-based tools are nowhere
near how great they were in the SVN era. This, of course, partially has to
do with complexity, but also with the audience: if the typical developer
uses linux, who will develop something great for windows?
GitHub has a nice GUI app for Windows which should
make it fairly easy to
send a pull request (which we then bridge straight into gerrit), or folks
may more easily use a different git front-end UI they prefer, if they don't
have to poke git-review directly.
In this case, I mainly used GitHub for Windows because it has some GH
integration - but it's nowhere near complete. The triangular push/pull
doesn't work without occasional hickups. I have contacted the GHfW team,
and they are working on a better integration. I could very well be the best
solution is via GitHub but not using GHfW - I'm still experimenting with
different options :-)
Alternatively, we could try to get git-review type
support into some of
those GUI tools...
Eclipse, using Mylyn, in theory has support for this. However, the Mylyn
Gerrit connector only works with 2.6, while we already use 2.7. They are
working on support [1], and I will try how well it works once I get it to
work. Unfortunately, it also means you have to deal with a lot of the
typical Eclipse 'I have a wizard, and it won't close'-type issues. GitEye
is basically a stripped down Eclipse with Mylyn and EGit.
I'm not sure how much effort it would be to add support to existing tools -
in the end, the Gerrit workflow is not that difficult - it basically adds
an 'commit to secondary branch and submit' option and a 'review' option.
It
might very well be worth the effort.
Merlijn
[1]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=412872