Hi. Some script stopped working. Looks like the function
$( '<div>' ).dialog( ... ) // 1 parameter
does not work any more. But it still works on different wiki. Was there some breaking change? Thank you. Igal (User:IKhitron)
Is the jquery.ui.dialog module loaded in RL? Where is this failing and where is it fine?
On Fri, 8 Feb 2019 at 14:47, יגאל חיטרון khitron@post.bgu.ac.il wrote:
Hi. Some script stopped working. Looks like the function
$( '<div>' ).dialog( ... ) // 1 parameter
does not work any more. But it still works on different wiki. Was there some breaking change? Thank you. Igal (User:IKhitron) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Works on hewiki. Does not on enwiki, eswiki, ruwiki. Thanks, Igal
בתאריך יום ו׳, 8 בפבר׳ 2019 ב-16:50 מאת Alex Monk <krenair@gmail.com >:
Is the jquery.ui.dialog module loaded in RL? Where is this failing and where is it fine?
On Fri, 8 Feb 2019 at 14:47, יגאל חיטרון khitron@post.bgu.ac.il wrote:
Hi. Some script stopped working. Looks like the function
$( '<div>' ).dialog( ... ) // 1 parameter
does not work any more. But it still works on different wiki. Was there some breaking change? Thank you. Igal (User:IKhitron) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
So, nobody knows what happened? If so, I should create a phab ticket. Igal On Feb 8, 2019 16:51, "יגאל חיטרון" khitron@post.bgu.ac.il wrote:
Works on hewiki. Does not on enwiki, eswiki, ruwiki. Thanks, Igal
בתאריך יום ו׳, 8 בפבר׳ 2019 ב-16:50 מאת Alex Monk <krenair@gmail.com >:
Is the jquery.ui.dialog module loaded in RL? Where is this failing and where is it fine?
On Fri, 8 Feb 2019 at 14:47, יגאל חיטרון khitron@post.bgu.ac.il wrote:
Hi. Some script stopped working. Looks like the function
$( '<div>' ).dialog( ... ) // 1 parameter
does not work any more. But it still works on different wiki. Was there some breaking change? Thank you. Igal (User:IKhitron) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi Igal, We are trying to avoid using jquery.ui in favor or OOUI to get a more modern interface. jquery dialog module is NOT loaded by default (and if it works for you in any wiki, likely you enabled some gadget that relay on it or it was enabled as default gadget) Though not all people like OOUI, and though it may be harder to do simple stuff, it provides some benefits when creating larger infrastructure of dialogs.
So the short answer wrap your function: mw.loader.using('jquery.ui.dialog', function() { $( '<div>' ).dialog( ... ) // 1 parameter })
The better way to do it: Follow https://www.mediawiki.org/wiki/OOUI/Windows/Dialogs
Eran
On Tue, Feb 12, 2019 at 9:45 PM יגאל חיטרון khitron@post.bgu.ac.il wrote:
So, nobody knows what happened? If so, I should create a phab ticket. Igal On Feb 8, 2019 16:51, "יגאל חיטרון" khitron@post.bgu.ac.il wrote:
Works on hewiki. Does not on enwiki, eswiki, ruwiki. Thanks, Igal
בתאריך יום ו׳, 8 בפבר׳ 2019 ב-16:50 מאת Alex Monk <
krenair@gmail.com
>:
Is the jquery.ui.dialog module loaded in RL? Where is this failing and where is it fine?
On Fri, 8 Feb 2019 at 14:47, יגאל חיטרון khitron@post.bgu.ac.il wrote:
Hi. Some script stopped working. Looks like the function
$( '<div>' ).dialog( ... ) // 1 parameter
does not work any more. But it still works on different wiki. Was
there
some breaking change? Thank you. Igal (User:IKhitron) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hello, Eran, and thank you. I had this using, of course. But it helped me to find the problem. I had mw.loader.using( [ 'jquery.ui.dialog', 'mediawiki.api', 'mediawiki.api.edit' ] I removed the 'mediawiki.api.edit', and it works now. Thank you, Igal
בתאריך יום ג׳, 12 בפבר׳ 2019 ב-23:31 מאת Eran Rosenthal < eranroz89@gmail.com>:
Hi Igal, We are trying to avoid using jquery.ui in favor or OOUI to get a more modern interface. jquery dialog module is NOT loaded by default (and if it works for you in any wiki, likely you enabled some gadget that relay on it or it was enabled as default gadget) Though not all people like OOUI, and though it may be harder to do simple stuff, it provides some benefits when creating larger infrastructure of dialogs.
So the short answer wrap your function: mw.loader.using('jquery.ui.dialog', function() { $( '<div>' ).dialog( ... ) // 1 parameter })
The better way to do it: Follow https://www.mediawiki.org/wiki/OOUI/Windows/Dialogs
Eran
On Tue, Feb 12, 2019 at 9:45 PM יגאל חיטרון khitron@post.bgu.ac.il wrote:
So, nobody knows what happened? If so, I should create a phab ticket. Igal On Feb 8, 2019 16:51, "יגאל חיטרון" khitron@post.bgu.ac.il wrote:
Works on hewiki. Does not on enwiki, eswiki, ruwiki. Thanks, Igal
בתאריך יום ו׳, 8 בפבר׳ 2019 ב-16:50 מאת Alex Monk <
krenair@gmail.com
>:
Is the jquery.ui.dialog module loaded in RL? Where is this failing and where is it fine?
On Fri, 8 Feb 2019 at 14:47, יגאל חיטרון khitron@post.bgu.ac.il wrote:
Hi. Some script stopped working. Looks like the function
$( '<div>' ).dialog( ... ) // 1 parameter
does not work any more. But it still works on different wiki. Was
there
some breaking change? Thank you. Igal (User:IKhitron) _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org