On 11/26/2010 5:01 PM, Mark A. Hershberger wrote:
mah(a)everybody.org (Mark A. Hershberger) writes:
I'm able to duplicate this on wikibooks in
IE8 and IE9. Interestingly,
the Wikibooks logo also disappears when I'm logged out.
The problem is caused
by the notice from CentralNotice. Whoever put in
the notice included<span class="plainlinks"> and did not close the span
tag. That span tag can be eliminated entirely.
If the plainlinks class is desired for some reason, it can still be used
by adding it to the list of classes for the a element:
class="external text plainlinks”
HTH,
Mark.
Thank you very much Mark, trying to track this down.
Interestingly none of our running banners had plainlinks running and
only 1 of them uses <span> tags (But without the class and closed right
after the text). We could definitely remove those tags, they aren't
really needed anymore but it doesn't appear to care which banner is
showing :-/ (in the US that banner is running at 5% and on English
projects without category 1 chapters it isn't running at all).
I removed the span tags
http://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-templat…
but I'm not sure those were the issue...
I did find a piece in our common style that someone added a couple
months ago to fix a problem we had with all our text banners.
/* Suppress lock icon for secure links */
#content a[href^="https://"], .link-https {
background-image: none !important;
padding: 0 !important;
}
I removed it (
http://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-shared-…
) since we don't have any banners that need it and it was the closest we
had... However the banner cache is clear at this point and I'm still
getting the problem on Wikibooks.
I'm poking through the code to try and find what it could be. Do you
remember where in the css you saw the open plainlinks span?
James
--
James Alexander
Associate Community Officer
Wikimedia Foundation
Jalexander(a)wikimedia.org
+1-415-839-6885 x6716