On Oct 12, 2014 10:13 AM, "Divyanshi Kathuria"
<divyanshikathuria(a)gmail.com>
wrote:
On Thu, Oct 09, 2014 at 09:54:03PM +0200, dan entous wrote:
this would be the best way to achieve what's needed. in any case, i
believe
this is the general idea antoine is getting at.
Thank You so much for your help. I have tried to incorporate data
providers
according to the changes you mentioned.
Here is the file :
https://gist.github.com/divyanshikathuria/e5a09b50f65779f92c69
Please see if it is correct and suggest the necessary
changes.
--
Divyanshi Kathuria
divyanshikathuria27.wordpress.com
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
No, that's not quite right (indentation is wrong, the @dataProvider
annotation needs to take the name of the function that is the provider not
just "Provider"). I suggest you try looking at other code that uses
@dataProvider to try to find an example, or read through the section of the
PHPUnit docs on data providers.
For this type of review like question, its probably better to ask on the
bug instead of the mailing list unless noone is responding on the bug.
--bawolff