Hi,
On Fri, 2021-08-13 at 09:14 +0200, tdvit@mail.com wrote:
Hello, I have just updated this extension https://www.mediawiki.org/wiki/Extension:CIForms and the related github repository. However, to update the code on gerrit here https://gerrit.wikimedia.org/g/mediawiki/extensions/CIForms I would need a code-reviewer. Anyone willing to help with this ?
Is this about https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043 as that is the only open changeset listed under https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?
I wonder if it makes sense to change the repository in Gerrit from "Merge review" to "Open push", assuming you are the sole developer? That would allow you to directly push (if I understand correctly).
Such changes should likely go directly into Gerrit, without having to fork a mirrored copy of the codebase on GitHub.
Cheers, andre
Hi,
On 8/13/21 6:21 AM, Andre Klapper wrote:
Is this about https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043 as that is the only open changeset listed under https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?
I wonder if it makes sense to change the repository in Gerrit from "Merge review" to "Open push", assuming you are the sole developer? That would allow you to directly push (if I understand correctly).
As a policy reason, we don't allow master/main of MediaWiki extensions/skins to be open push because it prevents having a space to discuss the pushed commit. Also, it bypasses any configured CI, potentially leaving the repo in a broken state.
However, if you're the sole/primary developer of an extension/skin, it's totally fine to just +2 your own change right after uploading it.
-- Legoktm
Hi, you can +2 it, I guess.
But I would like to point you to read some docs. :)
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP for coding convention and https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for how-to format a commit message.
If you have any questions, be free to ask me or anyone else here.
Best regards, Zoran
wikitech-l@lists.wikimedia.org