Thanks. From your response I'm not sure if these tests are "supposed" to fail (there are test suites that have tests like that) or they are supposed to succeed but there are bugs in the parser or other code that cause them to fail. Can you clarify?
--- On Tue, 7/14/09, Aryeh Gregor Simetrical+wikilist@gmail.com wrote:
From: Aryeh Gregor Simetrical+wikilist@gmail.com Subject: Re: [Wikitech-l] Is this the right list to ask questions about parserTests To: "Wikimedia developers" wikitech-l@lists.wikimedia.org Date: Tuesday, July 14, 2009, 3:40 PM On Tue, Jul 14, 2009 at 5:16 PM, dan nessettdnessett@yahoo.com wrote:
Can anyone tell me which of the parser tests are
supposed to fail? Also, is there a trunk version for which only these tests fail?
These are the perpetual failures:
13 still FAILING test(s) :( * Table security: embedded pipes (http://lists.wikimedia.org/mailman/htdig/wikitech-l/2006-April/022293.html) [Has never passed] * Link containing double-single-quotes '' (bug 4598) [Has never passed] * HTML bullet list, unclosed tags (bug 5497) [Has never passed] * HTML ordered list, unclosed tags (bug 5497) [Has never passed] * HTML nested bullet list, open tags (bug 5497) [Has never passed] * HTML nested ordered list, open tags (bug 5497) [Has never passed] * Inline HTML vs wiki block nesting [Has never passed] * dt/dd/dl test [Has never passed] * Images with the "|" character in the comment [Has never passed] * Bug 6200: paragraphs inside blockquotes (no extra line breaks) [Has never passed] * Bug 6200: paragraphs inside blockquotes (extra line break on open) [Has never passed] * Bug 6200: paragraphs inside blockquotes (extra line break on close) [Has never passed] * Bug 6200: paragraphs inside blockquotes (extra line break on open and close) [Has never passed]
r51509 is a revision on which they're the only failures, but it's pretty old (there's probably a somewhat more recent one). The breakage looks like it occurred in r52213 and r52726, according to
git bisect start trunk `git svn find-rev r51509` && git bisect run php phase3/maintenance/parserTests.php --regex 'Section headings with TOC' git bisect start trunk `git svn find-rev r51509` && git bisect run php phase3/maintenance/parserTests.php --regex '<references> after <gallery>'
(yay git!).
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Tue, Jul 14, 2009 at 6:50 PM, dan nessettdnessett@yahoo.com wrote:
Thanks. From your response I'm not sure if these tests are "supposed" to fail (there are test suites that have tests like that) or they are supposed to succeed but there are bugs in the parser or other code that cause them to fail. Can you clarify?
They're supposed to pass, in theory, but never have. Someone wrote the tests and the expected output at some point as a sort of to-do list. I don't know why we keep them, since they just confuse everything and make life difficult. (Using the --record and --compare options helps, but they're not that convenient.) All of them would require monkeying around with the parser that nobody's willing to do, since the parser is a hideous mess that no one understands or wants to deal with unless absolutely necessary.
wikitech-l@lists.wikimedia.org