On 07/06/07, amidaniel@svn.wikimedia.org amidaniel@svn.wikimedia.org wrote:
Revision: 22816 Author: amidaniel Date: 2007-06-07 17:31:08 +0000 (Thu, 07 Jun 2007)
Log Message:
(bug 7997) Added ability to Special:Blockip to block users from using Special:Emailuser.
$wgSysopEmailBans
Wouldn't it make more sense to introduce a new permission for that, which could sit on top of the standard "block" permission, rather than introduce another global?
Rob Church
On 6/7/07, Rob Church robchur@gmail.com wrote:
$wgSysopEmailBans
Wouldn't it make more sense to introduce a new permission for that, which could sit on top of the standard "block" permission, rather than introduce another global?
It may well -- would give us the ability to push it onto other usergroups if we need. The primary reason for using the global was that it's much more clear *how* to disable email-blocking, as this is likely something that many wikis will want to disable (at least, it's more clear than $wgGroupPermissions['sysop']['blockemail'] = false;). Everyone I asked about it felt as indifferent about it as I did though -- how 'bout we make a hybrid of the two? Have the global that will disable it regardless of who has what rights and the right itself which is also needed to use it?
It may well -- would give us the ability to push it onto other usergroups if we need. The primary reason for using the global was that it's much more clear *how* to disable email-blocking, as this is likely something that many wikis will want to disable (at least, it's more clear than $wgGroupPermissions['sysop']['blockemail'] = false;). Everyone I asked about it felt as indifferent about it as I did though -- how 'bout we make a hybrid of the two? Have the global that will disable it regardless of who has what rights and the right itself which is also needed to use it?
If you can't decide how to do something, let the user choose. It's always seemed a good philosophy to me.
On 07/06/07, Daniel Cannon cannon.danielc@gmail.com wrote:
it felt as indifferent about it as I did though -- how 'bout we make a hybrid of the two? Have the global that will disable it regardless of who has what rights and the right itself which is also needed to use it?
That makes sense. What I object to is the use of a global to manage user rights when we have a mechanism to do that.
Rob Church
On 6/7/07, Rob Church robchur@gmail.com wrote:
On 07/06/07, Daniel Cannon cannon.danielc@gmail.com wrote:
it felt as indifferent about it as I did though -- how 'bout we make a hybrid of the two? Have the global that will disable it regardless of
who
has what rights and the right itself which is also needed to use it?
That makes sense. What I object to is the use of a global to manage user rights when we have a mechanism to do that.
Committed as r22827.
On 07/06/07, Daniel Cannon cannon.danielc@gmail.com wrote:
Committed as r22827.
It's still $wgSysopUserBans, which is misleading. I recommend $wgEnableEmailBlocks or something.
Rob Church
On 6/7/07, Rob Church robchur@gmail.com wrote:
On 07/06/07, Daniel Cannon cannon.danielc@gmail.com wrote:
Committed as r22827.
It's still $wgSysopUserBans, which is misleading. I recommend $wgEnableEmailBlocks or something.
$wgSysopEmailBans. That was for consistency with $wgSysopUserBans and $wgSysopRangeBans. I don't care much for the name choice either, but I think it may be better to conform to the convention that's already been set for the ease of others. In any case, it's much easier for me to remember what variable does what if they all take the same form, even if the form may not be ideal.
wikitech-l@lists.wikimedia.org