All,
Over the past week or so, Roan, Brion and I have been getting CodeReview reviewed. We've just updated deployment from trunk, and I'd like to point out a few major things (plus of a bunch of other fixes, of course):
* Statistics on code review, specifically the "wall of shame" for fixmes[0] * A new 'old' status for revisions, basically for anything that is 2+ years old and still unreviewed[1] * Broken parser tests results system was removed, we've been using phpUnderControl for a little while now and it's a little more reliable :) [2]
Try things out and let us know if you see any (more) breakages.
-Chad
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/stats [1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/status/old [2] http://ci.tesla.usability.wikimedia.org/cruisecontrol/buildresults/mw
Chad wrote:
- Statistics on code review, specifically the "wall of shame" for fixmes[0]
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/stats
This was previously discussed on this list.[1] While it's more agnostic to look at "fixme"s for the entire repo, it's probably not the fairest counting mechanism. A "fixme" for a commit to a branch really isn't the same as a "fixme" for a commit to trunk.
MZMcBride
[1] http://lists.wikimedia.org/pipermail/wikitech-l/2010-August/049033.html
On Mon, Oct 11, 2010 at 11:10 AM, Chad innocentkiller@gmail.com wrote:
All,
Over the past week or so, Roan, Brion and I have been getting CodeReview reviewed. We've just updated deployment from trunk, and I'd like to point out a few major things (plus of a bunch of other fixes, of course):
- Statistics on code review, specifically the "wall of shame" for fixmes[0]
- A new 'old' status for revisions, basically for anything that is 2+ years
old and still unreviewed[1]
- Broken parser tests results system was removed, we've been using
phpUnderControl for a little while now and it's a little more reliable :) [2]
Woohoo! More scores to push up and down... :)
-- brion
Try things out and let us know if you see any (more) breakages.
-Chad
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/stats [1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/status/old [2] http://ci.tesla.usability.wikimedia.org/cruisecontrol/buildresults/mw
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Tue, Oct 12, 2010 at 2:10 AM, Chad innocentkiller@gmail.com wrote:
- Statistics on code review, specifically the "wall of shame" for fixmes[0]
Can "Number of revisions" rows be linked to a list of the author's fixme revisions?
Good to see you guys working on this...have to admit I read the title as "New CodeReview changes lives", and I thought maybe that was an inflated claim. But then again, maybe not ;-)
Danese
On 10/11/10 11:10 AM, Chad wrote:
All,
Over the past week or so, Roan, Brion and I have been getting CodeReview reviewed. We've just updated deployment from trunk, and I'd like to point out a few major things (plus of a bunch of other fixes, of course):
- Statistics on code review, specifically the "wall of shame" for fixmes[0]
- A new 'old' status for revisions, basically for anything that is 2+ years
old and still unreviewed[1]
- Broken parser tests results system was removed, we've been using
phpUnderControl for a little while now and it's a little more reliable :) [2]
Try things out and let us know if you see any (more) breakages.
-Chad
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/stats [1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/status/old [2] http://ci.tesla.usability.wikimedia.org/cruisecontrol/buildresults/mw
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org