An automated run of parserTests.php showed the following failures:
This is MediaWiki version 1.11alpha (r25338).
Reading tests from "maintenance/parserTests.txt"... Reading tests from "extensions/Cite/citeParserTests.txt"... Reading tests from "extensions/Poem/poemParserTests.txt"... Reading tests from "extensions/LabeledSectionTransclusion/lstParserTests.txt"...
1 previously failing test(s) now PASSING! :) * Fuzz testing: image with bogus manual thumbnail [Fixed between 30-Aug-2007 07:15:18, 1.11alpha (r25303) and 31-Aug-2007 07:15:36, 1.11alpha (r25338)]
1 previously passing test(s) now FAILING! :( * <references> after <gallery> (bug 6164) [Introduced between 30-Aug-2007 07:15:18, 1.11alpha (r25303) and 31-Aug-2007 07:15:36, 1.11alpha (r25338)]
17 still FAILING test(s) :( * URL-encoding in URL functions (single parameter) [Has never passed] * URL-encoding in URL functions (multiple parameters) [Has never passed] * Table security: embedded pipes (http://lists.wikimedia.org/mailman/htdig/wikitech-l/2006-April/022293.html) [Has never passed] * Link containing double-single-quotes '' (bug 4598) [Has never passed] * message transform: <noinclude> in transcluded template (bug 4926) [Has never passed] * message transform: <onlyinclude> in transcluded template (bug 4926) [Has never passed] * BUG 1887, part 2: A <math> with a thumbnail- math enabled [Has never passed] * HTML bullet list, unclosed tags (bug 5497) [Has never passed] * HTML ordered list, unclosed tags (bug 5497) [Has never passed] * HTML nested bullet list, open tags (bug 5497) [Has never passed] * HTML nested ordered list, open tags (bug 5497) [Has never passed] * Inline HTML vs wiki block nesting [Has never passed] * Mixing markup for italics and bold [Has never passed] * dt/dd/dl test [Has never passed] * Images with the "|" character in the comment [Has never passed] * Parents of subpages, two levels up, without trailing slash or name. [Has never passed] * Parents of subpages, two levels up, with lots of extra trailing slashes. [Has never passed]
Passed 526 of 544 tests (96.69%)... 18 tests failed!
On 8/31/07, brion@pobox.com brion@pobox.com wrote:
1 previously passing test(s) now FAILING! :( * <references> after <gallery> (bug 6164) [Introduced between 30-Aug-2007 07:15:18, 1.11alpha (r25303) and 31-Aug-2007 07:15:36, 1.11alpha (r25338)]
I think this was mainly r25335.
- <div class="thumb" style="padding: 66px 0; width: 150px;"><a href="/wiki/Image:Foobar.jpg" title="Image:Foobar.jpg"><img src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" alt="" /></a></div> + <div class="thumb" style="padding: 66px 0; width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" border="0" /></a></div></div>
Adds an extra <div style="margin-left: auto; margin-right: auto; width: 120px;"> (can't we use stylesheets for that? div.thumb div? or even div.thumb a, perhaps), an extra class="image" on the a element. More interesting is this part:
-src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" +src="http://example.com/images/3/3a/Foobar.jpg"
Doesn't that mean this has changed galleries to serve all images raw instead of thumbnailed?
Simetrical wrote:
On 8/31/07, brion@pobox.com brion@pobox.com wrote:
1 previously passing test(s) now FAILING! :( * <references> after <gallery> (bug 6164) [Introduced between 30-Aug-2007 07:15:18, 1.11alpha (r25303) and 31-Aug-2007 07:15:36, 1.11alpha (r25338)]
I think this was mainly r25335.
<div class="thumb" style="padding: 66px 0;width: 150px;"><a href="/wiki/Image:Foobar.jpg" title="Image:Foobar.jpg"><img src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" width="120" height="14" alt="" /></a></div>
<div class="thumb" style="padding: 66px 0;width: 150px;"><div style="margin-left: auto; margin-right: auto; width: 120px;"><a href="/wiki/Image:Foobar.jpg" class="image" title="Foobar.jpg"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" border="0" /></a></div></div>
Adds an extra <div style="margin-left: auto; margin-right: auto; width: 120px;"> (can't we use stylesheets for that? div.thumb div? or even div.thumb a, perhaps), an extra class="image" on the a element.
"div.thumb div" would break everything, so probably not advisable. Maybe you could have a special class just for this rule, but as you can see, I'm just replacing one style attribute with another that does the same thing in a more general case, so it's not a new issue.
If I had seen this before I committed it, I would have changed the expected output, like I did for the other ~30 parser tests I broke.
More interesting is this part:
-src="http://example.com/images/thumb/3/3a/Foobar.jpg/120px-Foobar.jpg" +src="http://example.com/images/3/3a/Foobar.jpg"
Doesn't that mean this has changed galleries to serve all images raw instead of thumbnailed?
That's what you get if no thumbnailing method is available on the server the test runs on, it falls back to client-side scaling. I got a normal thumb URL when I tried it on my test install.
-- Tim Starling
On 8/31/07, Tim Starling tstarling@wikimedia.org wrote:
That's what you get if no thumbnailing method is available on the server the test runs on, it falls back to client-side scaling. I got a normal thumb URL when I tried it on my test install.
Aha, that makes sense. I'll install ImageMagick locally and hopefully fewer tests will break.
wikitech-l@lists.wikimedia.org