On Fri, Mar 8, 2013 at 8:35 AM, Tyler Romeo tylerromeo@gmail.com wrote:
Is there any way that extension developers can get some sort of notice for breaking changes, e.g., https://gerrit.wikimedia.org/r/50138? Luckily my extension's JobQueue implementation hasn't been merged yet, but if it had I would have no idea that it had been broken by the core.
Hi Tyler,
Sorry to hear that there might be a problem here. It's been a pet peeve of mine that we seem to be a little too eager to break backwards compatibility in places where it may not be necessary. That said, let's try to avoid a meta-process discussion before we collectively understand the example you are bringing up, and focus on the JobQueue.
As near as I can tell from a quick skim of the changeset you're referencing, Aaron's changes here are purely additive. Am I reading this wrong? Is there some other changeset that changes/removes existing interfaces that you meant to reference instead?
Rob
On Fri, Mar 8, 2013 at 12:18 PM, Rob Lanphier robla@wikimedia.org wrote:
As near as I can tell from a quick skim of the changeset you're referencing, Aaron's changes here are purely additive. Am I reading this wrong? Is there some other changeset that changes/removes existing interfaces that you meant to reference instead?
At first glance it seems additive, but the change adds a new abstract method to the JobQueue class, meaning any child class of JobQueue that doesn't have the new method implemented will trigger a fatal error.
To make it not breaking, the function would have to have a default implementation in the main JobQueue class.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
Also, after doing a git-blame, I found https://gerrit.wikimedia.org/r/51886, which was also merged today. I could search through the core for other changes like this but it'd require an immense amount of time.
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
wikitech-l@lists.wikimedia.org