Antoine:
Would it be fairly easy for you to get Jenkins to automatically PHP lint-check new commits to extensions? Code reviewers would thank you!
Would it be fairly easy for you to get Jenkins to automatically PHP lint-check new commits to extensions? Code reviewers would thank you!
Also having unit tests get run automatically, and creating whatever necessary documentation for enabling developers to create consistent unit tests that *can* be run automatically, would be extremely helpful.
Hey,
+2.
Right now the Wikidata team is spending a lot of time manually running the tests, so it'd be absolutely fantastic if this could be done automatically.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --
If we do this running jslint on JavaScript would also be great. I have a git hook I stole from Yuvi that I'm currently using. Would be great to have Jenkins do this check for me as well... On Jul 5, 2012 1:32 PM, "Mark Holmquist" marktraceur@riseup.net wrote:
Would it be fairly easy for you to get Jenkins to automatically PHP
lint-check new commits to extensions? Code reviewers would thank you!
Also having unit tests get run automatically, and creating whatever necessary documentation for enabling developers to create consistent unit tests that *can* be run automatically, would be extremely helpful.
-- Mark Holmquist Contractor, Wikimedia Foundation mtraceur@member.fsf.org http://marktraceur.info
______________________________**_________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Thu, Jul 5, 2012 at 1:37 PM, Jon Robson jdlrobson@gmail.com wrote:
If we do this running jslint on JavaScript would also be great. I have a git hook I stole from Yuvi that I'm currently using. Would be great to have Jenkins do this check for me as well...
I believe Timo is already working on getting jshint working on the command line. There's a few commits to .jshint and .jshintignore (IIRC) that are currently pending review.
Roan
On Thu, Jul 5, 2012 at 5:06 PM, Roan Kattouw roan.kattouw@gmail.com wrote:
On Thu, Jul 5, 2012 at 1:37 PM, Jon Robson jdlrobson@gmail.com wrote:
If we do this running jslint on JavaScript would also be great. I have a git hook I stole from Yuvi that I'm currently using. Would be great to have Jenkins do this check for me as well...
I believe Timo is already working on getting jshint working on the command line. There's a few commits to .jshint and .jshintignore (IIRC) that are currently pending review.
Yes, but we can't even get people to type `php -l` before pushing, which is why having Jenkins do this for us is crucial.
-Chad
On Thu, Jul 5, 2012 at 2:11 PM, Chad innocentkiller@gmail.com wrote:
Yes, but we can't even get people to type `php -l` before pushing, which is why having Jenkins do this for us is crucial.
Yes, I don't disagree that jshint should be run by Jenkins. AIUI Timo's work to make jshint work on the command line is prep work for exactly that.
Roan
On Thu, Jul 5, 2012 at 7:06 PM, Roan Kattouw roan.kattouw@gmail.com wrote:
On Thu, Jul 5, 2012 at 2:11 PM, Chad innocentkiller@gmail.com wrote:
Yes, but we can't even get people to type `php -l` before pushing, which is why having Jenkins do this for us is crucial.
Yes, I don't disagree that jshint should be run by Jenkins. AIUI Timo's work to make jshint work on the command line is prep work for exactly that.
Ah, I misunderstood you. Thought you meant "so people can run it before uploading" which no one will ever do ;-)
-Chad
Yes, I don't disagree that jshint should be run by Jenkins. AIUI Timo's work to make jshint work on the command line is prep work for exactly that.
Ah, I misunderstood you. Thought you meant "so people can run it before uploading" which no one will ever do ;-)
Maybe we should create a git pre-commit script that does the jslint / php -c check that people can install on their local dev computers. That way people will never forget it ;)
D
Sumana Harihareswara wrote:
Would it be fairly easy for you to get Jenkins to automatically PHP lint-check new commits to extensions? Code reviewers would thank you!
It is not trivially easy. I am currently focusing on implementing the test for the Wikidata branch and the Wikibase extension. Still a work in progress though.
My next targets are MobileFrontend and ArticleFeedbackv5 which I will implement manually.
After that, I will write a script to generate the Jenkins jobs automatically based on the list of extensions hosted on Gerrit:
https://gerrit.wikimedia.org/mediawiki-extensions.txt
wikitech-l@lists.wikimedia.org