grondin@svn.wikimedia.org schreef:
Revision: 29702 Author: grondin Date: 2008-01-13 20:25:23 +0000 (Sun, 13 Jan 2008)
Log Message:
Fixed bug for loading internationalization messages
I don't know exactly what's being fixed here, but the entire point of all those separate wfLoadExtensionMessages() call was not to load messages unless it's really necessary (this has been done to a lot of extensions lately). Your fix undoes this optimization.
Roan Kattouw (Catrope)
It also makes the the text for the special page visible again, instead of "<oversight<" or something similar.
I know it's a trade off, but the general consensus is that messages are better than message IDs in UIs. ;)
Cheers! Siebrand
-----Oorspronkelijk bericht----- Van: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] Namens Roan Kattouw Verzonden: zondag 13 januari 2008 21:36 Aan: wikitech-l@lists.wikimedia.org Onderwerp: Re: [Wikitech-l] [MediaWiki-CVS] SVN:[29702] trunk/extensions/Oversight/HideRevision.php
Revision: 29702
Fixed bug for loading internationalization messages
I don't know exactly what's being fixed here, but the entire point of all those separate wfLoadExtensionMessages() call was not to load messages unless it's really necessary (this has been done to a lot of extensions lately). Your fix undoes this optimization.
Roan Kattouw (Catrope)
Siebrand Mazeland schreef:
It also makes the the text for the special page visible again, instead of "<oversight<" or something similar.
I know it's a trade off, but the general consensus is that messages are better than message IDs in UIs. ;)
If that's the case, wfLoadExtensionMessages() should be in whatever function provides the specialpage aliases for HideRevision. I know for one thing that this works with ChangeAuthor (also in SVN).
Roan Kattouw (Catrope)
wikitech-l@lists.wikimedia.org