I just stumbled across https://github.com/wikimedia/mediawiki-core/pull/19, a small but useful contribution to core from an HHVM developer. It has gone unnoticed for two months, which is a bit sad.
Is there a way to accept pull-requests from GitHub? According to < https://github.com/wikimedia/mediawiki-core/settings/hooks%3E (may not be visible to non-Wikimedians, sorry), the WebHook receiver < http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py%3E is defunct. Anyone know the story there?
It'd be good if some additional people were watching (that is, receiving notifications for) https://github.com/wikimedia/mediawiki-core/.
I haven't responded yet, by the way, so feel free to if you know the answers to these questions. I don't know what effect accepting the pull-request will have on the code in master, and telling someone who has already submitted a patch to go sign up for Gerrit seems impolite.
Ori
It is possible to copy the pull request to Gerrit easily: paste the contents of https://github.com/wikimedia/mediawiki-core/pull/19.patch into https://tools.wmflabs.org/gerrit-patch-uploader/ and bonk the button. This is of course a one-time, one-way synchronisation.
YuviPanda used to have a bot that provided two-way synchronisation between Gerrit changesets and GitHub pull requests, but I haven't seen it used recently and I don't know where to find the source code or anything.
On Fri, 18 Apr 2014 10:21:43 +0200, Ori Livneh ori@wikimedia.org wrote:
Is there a way to accept pull-requests from GitHub? According to < https://github.com/wikimedia/mediawiki-core/settings/hooks%3E (may not be visible to non-Wikimedians, sorry), the WebHook receiver < http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py%3E is defunct. Anyone know the story there?
Oh, I think that's actually "backend" for Yuvi's bot (it was called "SuchABot").
In this case, the developer was replied to by Krenair in a second PR they opened for the same issue, so at least they weren't ignored, just looks like the first PR wasn't closed along with the second one: https://github.com/wikimedia/mediawiki-core/pull/20
The code for Yuvi's SuchABot is here: https://git.wikimedia.org/tree/labs%2Ftools%2FSuchABot.git
Cheers, grunny
As for notifications just turn the IRC hook on an point it at wikimedia-dev for the repos?
WMDE do a similar thing for all of their github repos, see the following script which makes it a lot easier! https://github.com/wmde/github-hook-updater
Addshore
On 18 April 2014 10:31, Grunny mwgrunny@gmail.com wrote:
In this case, the developer was replied to by Krenair in a second PR they opened for the same issue, so at least they weren't ignored, just looks like the first PR wasn't closed along with the second one: https://github.com/wikimedia/mediawiki-core/pull/20
The code for Yuvi's SuchABot is here: https://git.wikimedia.org/tree/labs%2Ftools%2FSuchABot.git
Cheers, grunny
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On 04/18/2014 04:21 AM, Ori Livneh wrote:
Is there a way to accept pull-requests from GitHub?
I don't think we can merge directly there. The canonical repo is git.wikimedia.org, and I think merging in GitHub would create an inconsistent state.
According to < https://github.com/wikimedia/mediawiki-core/settings/hooks%3E (may not be visible to non-Wikimedians, sorry), the WebHook receiver < http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py%3E is defunct. Anyone know the story there?
It would be good to get this bot (which uploads things to Gerrit) up and running again. I'm not sure what the current status is.
It'd be good if some additional people were watching (that is, receiving notifications for) https://github.com/wikimedia/mediawiki-core/.
I've watched it.
Matt Flaschen
On Fri, Jul 11, 2014 at 11:34 AM, Matthew Flaschen mflaschen@wikimedia.org wrote:
On 04/18/2014 04:21 AM, Ori Livneh wrote:
Is there a way to accept pull-requests from GitHub?
I don't think we can merge directly there. The canonical repo is git.wikimedia.org, and I think merging in GitHub would create an inconsistent state.
The canonical repo source is gerrit.wikimedia.org.
git.wikimedia.org is a mirror.
But otherwise yes, you're right.
-Chad
Le 11/07/2014 20:34, Matthew Flaschen a écrit :
According to < https://github.com/wikimedia/mediawiki-core/settings/hooks%3E (may not be visible to non-Wikimedians, sorry), the WebHook receiver < http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py%3E is defunct. Anyone know the story there?
It would be good to get this bot (which uploads things to Gerrit) up and running again. I'm not sure what the current status is.
There is a manual tool at:
https://tools.wmflabs.org/gerrit-patch-uploader/ https://gerrit.wikimedia.org/r/#/q/owner:gerritpatchuploader,n,z
Krenair manually warned some folks on Github about having to send the patches to Gerrit.
What would be nice: disable pull requests on Github.
If not supported, have a bot detecting such pull requests and autoclose them with instructions about how to create an account on labs and push a change.
On 11 July 2014 19:49, Antoine Musso hashar+wmf@free.fr wrote:
If not supported, have a bot detecting such pull requests and autoclose them with instructions about how to create an account on labs and push a change.
If I remember correctly, Yuvi had a bot that did something like this. It broke in some way and no one has fixed it.
On 07/11/2014 02:54 PM, Alex Monk wrote:
On 11 July 2014 19:49, Antoine Musso hashar+wmf@free.fr wrote:
If not supported, have a bot detecting such pull requests and autoclose them with instructions about how to create an account on labs and push a change.
If I remember correctly, Yuvi had a bot that did something like this. It broke in some way and no one has fixed it.
Yep, I think this is the best solution. It automatically uploads a change to Gerrit when someone posts a pull request.
I talked to Yuvi on IRC, and he is hoping to make time to fix it next week.
Matt Flaschen
On Fri, Jul 11, 2014 at 11:49 AM, Antoine Musso hashar+wmf@free.fr wrote:
What would be nice: disable pull requests on Github.
If not supported, have a bot detecting such pull requests and autoclose them with instructions about how to create an account on labs and push a change.
Not possible to disable.
-Chad
On 11 July 2014 21:49, Antoine Musso hashar+wmf@free.fr wrote:
There is a manual tool at:
https://tools.wmflabs.org/gerrit-patch-uploader/ https://gerrit.wikimedia.org/r/#/q/owner:gerritpatchuploader,n,z
I have plans to extend the uploader to allow simpele github uploads (just like the bugzilla option), but I have not had time to work on this yet. If anyone feels like working on it: see https://github.com/valhallasw/gerrit-patch-uploader/blob/master/patchuploade... for the existing download-a-patch-from-bugzilla implementation. I'd happily merge a patch for a one-click github uploader.
Merlijn
On Fri, 11 Jul 2014 21:35:56 +0200, Merlijn van Deen valhallasw@arctus.nl wrote:
I have plans to extend the uploader to allow simpele github uploads (just like the bugzilla option), but I have not had time to work on this yet. If anyone feels like working on it: see https://github.com/valhallasw/gerrit-patch-uploader/blob/master/patchuploade... for the existing download-a-patch-from-bugzilla implementation. I'd happily merge a patch for a one-click github uploader.
For anyone planning to work on this, a tip: you can add ".patch" or ".diff" to a GitHub pull request URL to get a Gerrit-Patch-Uploader-compatible patch, e.g. https://github.com/wikimedia/mediawiki-core/pull/19.diff
On Fri, Jul 11, 2014 at 2:49 PM, Antoine Musso hashar+wmf@free.fr wrote:
Le 11/07/2014 20:34, Matthew Flaschen a écrit :
According to < https://github.com/wikimedia/mediawiki-core/settings/hooks%3E (may not be visible to non-Wikimedians, sorry), the WebHook receiver < http://tools.wmflabs.org/suchaserver/cgi-bin/receiver.py%3E is defunct. Anyone know the story there?
It would be good to get this bot (which uploads things to Gerrit) up and running again. I'm not sure what the current status is.
There is a manual tool at:
https://tools.wmflabs.org/gerrit-patch-uploader/ https://gerrit.wikimedia.org/r/#/q/owner:gerritpatchuploader,n,z
Krenair manually warned some folks on Github about having to send the patches to Gerrit.
What would be nice: disable pull requests on Github.
If not supported, have a bot detecting such pull requests and autoclose them with instructions about how to create an account on labs and push a change.
I personally think that fixing up Merlijn's Gerrit patch uploader would lead to a far superior developer experience.
wikitech-l@lists.wikimedia.org