Hi all,
here is our update on last weeks blocker email. Most of them are very small, besides the well known gorrilas in the gerrit...
== Ongoing from last week ==
* Changeset https://gerrit.wikimedia.org/r/#/c/14084/, bug https://bugzilla.wikimedia.org/show_bug.cgi?id=38705 about adding ll_local to the languagelinks table: as per discussion, there's a -2 from Tim Starling and further comments which were answered by Jeroen. Awaiting either further reply by Tim, or a merge. Development of core parts of our Phase I functionality is blocked by this, and not having this merged is causing hassle for people that want to setup their own working Wikidata repo-client install.
* Changeset https://gerrit.wikimedia.org/r/#/c/14295/, bug https://bugzilla.wikimedia.org/show_bug.cgi?id=38705 about handling sites: Wikidata could benefit from some refactoring of the interlanguage and interwiki link handling in core. The idea is to migrate from the "interwiki" table to the new "Sites" facility. RobLa mentioned that Chad seems to be working in a similar direction, but haven't seen comments there. Besides that there were a few comments going back and forth. A Postgres-compatibility is being requested by saper, which will soon be added, but the question is are there any further issues that prevent us from merging?
* Merging the Wikidata branch (ContentHandler) is still in discussion, see https://bugzilla.wikimedia.org/show_bug.cgi?id=38622. Daniel Kinzler hopes to have the discussion here on wikitech-l about this. Right now there seems a bit of a confusion due to Gerrit (if you look at the bug comments), but otherwise ongoing.
== New in the list ==
* Changeset https://gerrit.wikimedia.org/r/#/c/8924/, 'usecheckboxes' option implemented for HTMLMultiSelectField. Helps us with displaying some preferences nicely with a scrollable multiselect-list. Hanging around for a while and needs review and merge. Some discussion last week.
* New hook 'AfterFinalPageOutput' which is called at the end of OutputPage::output() https://gerrit.wikimedia.org/r/#/c/14303/: Got a little stuck and is required by the STTLanguage extension. (in parallel, this is in the Wikidata branch of core already, but would be removed from there if accepted here).
* Linker::link() handles strings in $query parameter properly now, changeset: https://gerrit.wikimedia.org/r/#/c/14301/. Some concerns were raised whether this should be fixed in other places instead. Fixing this in all other places and especially testing it there could be rather expensive. This is required by the STTLanguage extension. If this isn't fixed, the function might fail in some places, e.g. on the latest changes page. (in parallel, this is in the Wikidata branch of core already, but would be removed from there if accepted here)
* A change to the skin that will allow us to add the description of an item: changeset https://gerrit.wikimedia.org/r/#/c/17073/. There discussion and development is ongoing.
I hope this helps, Cheers, Denny
And drop the following one, it was just abandoned after internal discussion. Yay, less work!
2012/8/2 Denny Vrandečić denny.vrandecic@wikimedia.de:
- Changeset https://gerrit.wikimedia.org/r/#/c/14084/, bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=38705 about adding ll_local to the languagelinks table: as per discussion, there's a -2 from Tim Starling and further comments which were answered by Jeroen. Awaiting either further reply by Tim, or a merge. Development of core parts of our Phase I functionality is blocked by this, and not having this merged is causing hassle for people that want to setup their own working Wikidata repo-client install.
Hi Denny,
Thanks for the update! More inline...
On Thu, Aug 2, 2012 at 9:28 AM, Denny Vrandečić denny.vrandecic@wikimedia.de wrote:
== Ongoing from last week ==
[...]
- Changeset https://gerrit.wikimedia.org/r/#/c/14295/, bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=38705 about handling sites: Wikidata could benefit from some refactoring of the interlanguage and interwiki link handling in core. The idea is to migrate from the "interwiki" table to the new "Sites" facility. RobLa mentioned that Chad seems to be working in a similar direction, but haven't seen comments there. Besides that there were a few comments going back and forth. A Postgres-compatibility is being requested by saper, which will soon be added, but the question is are there any further issues that prevent us from merging?
This one probably deserves its own thread on the list, which you all probably shouldn't wait for me to start (please don't reply to this without changing the subject)
- Merging the Wikidata branch (ContentHandler) is still in discussion,
see https://bugzilla.wikimedia.org/show_bug.cgi?id=38622. Daniel Kinzler hopes to have the discussion here on wikitech-l about this. Right now there seems a bit of a confusion due to Gerrit (if you look at the bug comments), but otherwise ongoing.
Looking forward to the discussion. I spoke with Tim last night about this one, so I'm glad things are moving now. I'm a little dismayed that it was possible to scramble Gerrit like it was.
== New in the list ==
- Changeset https://gerrit.wikimedia.org/r/#/c/8924/,
'usecheckboxes' option implemented for HTMLMultiSelectField. Helps us with displaying some preferences nicely with a scrollable multiselect-list. Hanging around for a while and needs review and merge. Some discussion last week.
Andrew totally cookie-licked this one, which I just pointed out to him in person. You have my blessing to set up a cron job to remind him to follow through :-)
- New hook 'AfterFinalPageOutput' which is called at the end of
OutputPage::output() https://gerrit.wikimedia.org/r/#/c/14303/: Got a little stuck and is required by the STTLanguage extension. (in parallel, this is in the Wikidata branch of core already, but would be removed from there if accepted here).
Looks like there's a -1 on this one as of this writing.
- Linker::link() handles strings in $query parameter properly now,
changeset: https://gerrit.wikimedia.org/r/#/c/14301/. Some concerns were raised whether this should be fixed in other places instead. Fixing this in all other places and especially testing it there could be rather expensive. This is required by the STTLanguage extension. If this isn't fixed, the function might fail in some places, e.g. on the latest changes page. (in parallel, this is in the Wikidata branch of core already, but would be removed from there if accepted here)
If you all are blocked, the short term fix is to fix your usage of this API, but not worry about enforcing the array convention everywhere. If you have code that takes this variable as input, that's probably where the backwards-compatibility cruft should temporarily go.
What would be a better core change is a test there marking use of string as deprecated, so that we can start cleaning up the deprecation warnings.
- A change to the skin that will allow us to add the description of an
item: changeset https://gerrit.wikimedia.org/r/#/c/17073/. There discussion and development is ongoing.
Okee doke.
Rob
wikitech-l@lists.wikimedia.org