Do they work correctly? Some metadata tests have been failing to me for a long time, though I didn't bother to find out the root cause.
If that code is yours, you may want to take a look.
More specifically: FormatMetadataTest::testInvalidDate BitmapMetadataHandlerTest::testMultilingualCascade JpegTest::testJpegMetadataExtraction ExifRotationTest::testMetadata (dataset #1) ExifRotationTest::testWidthFlipping
Results in REL1.18 are a bit different, although they look to be older tests?
That's concerning. They work for me perfectly fine and seem to work on cruise control. What's the error they're failing with?
Thanks, Bawolff
bawolff wrote:
That's concerning. They work for me perfectly fine and seem to work on cruise control. What's the error they're failing with?
Thanks, Bawolff
It may just be that I don't have something properly configured locally.
This is a run of make databaseless on trunk.
There were 5 failures:
- FormatMetadataTest::testInvalidDate
Valid metadata extracted Failed asserting that boolean:false is not equal to boolean:false.
tests/phpunit/includes/media/FormatMetadataTest.php:13 tests/phpunit/MediaWikiTestCase.php:64 tests/phpunit/MediaWikiPHPUnitCommand.php:31 tests/phpunit/phpunit.php:60
- BitmapMetadataHandlerTest::testMultilingualCascade
Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( [_type] => lang [en] => right translation
- [x-default] => right(iptc)
- [x-default] => An example image (wrong should not show this)
)
tests/phpunit/includes/media/BitmapMetadataHandlerTest.php:33 tests/phpunit/MediaWikiTestCase.php:64 tests/phpunit/MediaWikiPHPUnitCommand.php:31 tests/phpunit/phpunit.php:60
- JpegTest::testJpegMetadataExtraction
Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array (
- [ImageDescription] => Test file
@@ @@ [MEDIAWIKI_EXIF_VERSION] => 2
- [ResolutionUnit] => 2
- [XResolution] => 72/1
- [YCbCrPositioning] => 1
- [YResolution] => 72/1
)
tests/phpunit/includes/media/JpegTest.php:25 tests/phpunit/MediaWikiTestCase.php:64 tests/phpunit/MediaWikiPHPUnitCommand.php:31 tests/phpunit/phpunit.php:60
- ExifRotationTest::testMetadata with data set #1 ('portrait-rotated.jpg', 'image/jpeg', array(768, 1024))
portrait-rotated.jpg: post-rotation width check Failed asserting that integer:768 matches expected integer:1024.
tests/phpunit/includes/media/ExifRotationTest.php:42 tests/phpunit/MediaWikiTestCase.php:64 tests/phpunit/MediaWikiPHPUnitCommand.php:31 tests/phpunit/phpunit.php:60
- ExifRotationTest::testWidthFlipping
Failed asserting that double:38 matches expected integer:50.
tests/phpunit/includes/media/ExifRotationTest.php:109 tests/phpunit/MediaWikiTestCase.php:64 tests/phpunit/MediaWikiPHPUnitCommand.php:31 tests/phpunit/phpunit.php:60
wikitech-l@lists.wikimedia.org