tstarling@svn.wikimedia.org wrote:
Revision: 29361 Author: tstarling Date: 2008-01-07 05:38:19 +0000 (Mon, 07 Jan 2008)
Log Message:
Added RepoGroup::setSingleton(). Required to support the DumpHTML extension.
Reverted this as it broke uploads...
unlink( $dstPath );
$this->unlink( $dstPath );
[snip]
chmod( $dstPath, 0644 );
$this->chmod( $dstPath, 0644 );
These don't exist. If they're needed, should they be added?
-- brion vibber (brion @ wikimedia.org)
Brion Vibber schreef:
unlink( $dstPath );
$this->unlink( $dstPath );[snip]
chmod( $dstPath, 0644 );
$this->chmod( $dstPath, 0644 );These don't exist. If they're needed, should they be added?
I don't really get that; unlink(), chmod() and file_get_contents() are built-in PHP functions, why would you want to wrap around them in a class?
Roan Kattouw (Catrope)
Brion Vibber wrote:
tstarling@svn.wikimedia.org wrote:
Revision: 29361 Author: tstarling Date: 2008-01-07 05:38:19 +0000 (Mon, 07 Jan 2008)
Log Message:
Added RepoGroup::setSingleton(). Required to support the DumpHTML extension.
Reverted this as it broke uploads...
unlink( $dstPath );
$this->unlink( $dstPath );[snip]
chmod( $dstPath, 0644 );
$this->chmod( $dstPath, 0644 );These don't exist. If they're needed, should they be added?
Sorry about that, that was code from another project. I should have reverted it a while ago, since it didn't go anywhere.
-- Tim Starling
wikitech-l@lists.wikimedia.org