On 9/10/07, werdna(a)svn.wikimedia.org <werdna(a)svn.wikimedia.org> wrote:
- if( $wgUser->isAllowed(
'rollback' ) ) {
+ if( $wgUser->isAllowed( 'rollback' ) &&
$this->mTitle->userCan( 'edit' ) ) {
Doesn't it make more sense to check $this->mTitle->userCan( 'rollback'
) (making any associated changes needed to userCan)? By default it
can just call userCan( 'edit' ), of course, but it's not coherent to
hardcode that into the call syntax.