Hey you out there -- have you submitted bug fix patches that haven't been applied yet? (I'm pretty sure there are a few.) I know that's awful frustrating...
If so, please repost them here so we can get these committed or corrected and move on to the next set of fun bugs. :)
If possible, do a 'cvs diff -u' against the current main CVS branch so it can integrate cleanly. Mail often munges plaintext patches, so please either attach a gzipped copy or just post a URL. (If there's a relevant bug report on SourceForge, you can upload the file there.)
-- brion vibber (brion @ pobox.com)
Brion Vibber wrote:
If so, please repost them here so we can get these committed or corrected and move on to the next set of fun bugs. :)
This (once again) fixes the sort ordering in SpecialLonelypages:
Index: includes/SpecialLonelypages.php =================================================================== RCS file: /cvsroot/wikipedia/phase3/includes/SpecialLonelypages.php,v retrieving revision 1.11 diff -u -r1.11 SpecialLonelypages.php --- includes/SpecialLonelypages.php 18 Jul 2004 08:48:25 -0000 1.11 +++ includes/SpecialLonelypages.php 31 Jul 2004 12:49:35 -0000 @@ -11,7 +11,11 @@ function isExpensive() { return true; } - + + function sortDescending() { + return false; + } + function getSQL() { $dbr =& wfGetDB( DB_SLAVE ); extract( $dbr->tableNames( 'cur', 'links' ) );
Alwin Meschede
Alwin Meschede wrote:
This (once again) fixes the sort ordering in SpecialLonelypages:
- function sortDescending() {
return false;- }
What exactly is the problem this is supposed to be fixing, and why does this fix it? I don't currently see a sort ordering problem on Special:Lonelypages.
Timwi
Timwi schrieb:
Alwin Meschede wrote:
This (once again) fixes the sort ordering in SpecialLonelypages:
- function sortDescending() {
return false;- }
What exactly is the problem this is supposed to be fixing, and why does this fix it? I don't currently see a sort ordering problem on Special:Lonelypages.
I don't see it on the live site (might be due to caching) but on my local installation. Look at http://wikidev.net/Special:Lonelypages in Gabriel's wiki: The sort order is z-a. My patch makes sure it's a-z.
Alwin Meschede
Alwin Meschede wrote:
I don't see it on the live site (might be due to caching) but on my local installation. Look at http://wikidev.net/Special:Lonelypages in Gabriel's wiki: The sort order is z-a. My patch makes sure it's a-z.
OK, I've committed your patch.
Thanks!
Timwi wrote:
Alwin Meschede wrote:
I don't see it on the live site (might be due to caching) but on my local installation. Look at http://wikidev.net/Special:Lonelypages in Gabriel's wiki: The sort order is z-a. My patch makes sure it's a-z.
OK, I've committed your patch.
While that patch changes order to A-Z with $wgMiserMode off, it changes it *to* Z-A when loading the cached results back up with $wgMiserMode on (as on the Wikipedia installations).
This still needs some work.
-- brion vibber (brion @ pobox.com)
On Friday 30 July 2004 23:02, Brion Vibber wrote:
Hey you out there -- have you submitted bug fix patches that haven't been applied yet? (I'm pretty sure there are a few.) I know that's awful frustrating...
I have a few larger patches that haven't been applied yet, but they aren't bugfixes.
Anyway, here is one small bugfix, which I haven't submitted before. Difference engine sometimes inserts ISO-8859-1 non-breaking space in the output which on UTF-8 wikis appear as a square or question mark in some browsers (for example, see http://sr.wikipedia.org/w/wiki.phtml?title=%D0%A1%D1%80%D0%BF%D1%81%D0%BA%D0... ). It changes the ISO NBSP into the entity which is seen properly regardless of the site's encoding.
Nikola Smolenski wrote:
Anyway, here is one small bugfix, which I haven't submitted before. Difference engine sometimes inserts ISO-8859-1 non-breaking space in the output which on UTF-8 wikis appear as a square or question mark in some browsers (for example, see http://sr.wikipedia.org/w/wiki.phtml?title=%D0%A1%D1%80%D0%BF%D1%81%D0%BA%D0... ). It changes the ISO NBSP into the entity which is seen properly regardless of the site's encoding.
Ah, thanks!
I've committed and installed a slight variation: I used the numeric   rather than since seems to be problematic in pure XHTML mode in some browsers (Safari at least). (Only a few of the named character entities are actually defined by raw XML.) It won't make a difference on the Wikimedia installations since we're using the text/html mode.
-- brion vibber (brion @ pobox.com)
On Monday 02 August 2004 03:46, Brion Vibber wrote:
Nikola Smolenski wrote:
Anyway, here is one small bugfix, which I haven't submitted before. Difference engine sometimes inserts ISO-8859-1 non-breaking space in the output which on UTF-8 wikis appear as a square or question mark in some browsers (for example, see http://sr.wikipedia.org/w/wiki.phtml?title=%D0%A1%D1%80%D0%BF%D1%81%D0%BA %D0%B0_%D0%BF%D1%80%D0%B0%D0%B2%D0%BE%D1%81%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0_ %D1%86%D1%80%D0%BA%D0%B2%D0%B0&diff=4374&oldid=4309 ). It changes the ISO NBSP into the entity which is seen properly regardless of the site's encoding.
Ah, thanks!
Nothing :)
I've committed and installed a slight variation: I used the numeric   rather than since seems to be problematic in pure XHTML mode in some browsers (Safari at least). (Only a few of the named character entities are actually defined by raw XML.) It won't make a difference on the Wikimedia installations since we're using the text/html mode.
Should then each be converted to  ?
config/index.php:1 extensions/BoardVote/BoardVote.php:3 includes/Article.php:4 includes/DifferenceEngine.php:3 includes/Parser.php:4 includes/Skin.php:10 includes/SpecialAsksql.php:1 includes/SpecialBlockip.php:1 includes/SpecialEmailuser.php:1 includes/SpecialIpblocklist.php:1 includes/SpecialLockdb.php:1 includes/SpecialMakesysop.php:2 includes/SpecialMovepage.php:1 includes/SpecialUnlockdb.php:1 includes/SpecialUpload.php:1 includes/SpecialUserlogin.php:3 includes/Tokenizer.php:1 includes/Parser.php1:4 languages/Language.php:2 languages/LanguageAr.php:2 languages/LanguageBg.php:3 languages/LanguageBn.php:1 languages/LanguageCs.php:1 languages/LanguageCy.php:1 languages/LanguageDa.php:1 languages/LanguageDe.php:2 languages/LanguageEt.php:1 languages/LanguageFa.php:1 languages/LanguageFi.php:1 languages/LanguageFr.php:3 languages/LanguageFy.php:1 languages/LanguageGa.php:1 languages/LanguageHu.php:1 languages/LanguageIa.php:1 languages/LanguageIt.php:1 languages/LanguageKo.php:1 languages/LanguageMs.php:1 languages/LanguageNl.php:1 languages/LanguagePt.php:1 languages/LanguageRo.php:1 languages/LanguageRu.php:1 languages/LanguageSc.php:1 languages/LanguageSk.php:1 languages/LanguageSq.php:1 languages/LanguageSr.php:1 languages/LanguageSv.php:1 languages/LanguageTa.php:1 languages/LanguageTh.php:1 math/lexer.mll:4 math/texutil.ml:3 templates/xhtml_slim.pt:2
wikitech-l@lists.wikimedia.org