That should be a part of your patch, renaming the files. If you renamed via svn, then it should be included in your unified diff. Fwiw, is there any compelling reason to change them all to .inc? The majority seem to be .inc.php.
-Chad
On May 15, 2009 9:40 PM, "Karun Dambiec" karun@fastmail.fm wrote:
Hello, I have been working on a patch for Bug 18698 which is where we have inconsistent file naming standards being .inc and .inc.php
The patch I have created corrects the file naming to .inc in the affected files. Once it has been reviewed and after that, is there some form of procedure or process that exists to have files renamed?
Regards -- Karun Dambiec karun@fastmail.fm
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Fri, 15 May 2009 21:44 -0400, "Chad" innocentkiller@gmail.com wrote:
That should be a part of your patch, renaming the files. If you renamed via svn, then it should be included in your unified diff. Fwiw, is there any compelling reason to change them all to .inc? The majority seem to be .inc.php.
-Chad
I wasnt aware SVN had a rename option. Ill update the patch to include renaming the files. Probably the main reason to rename them is that in the maintenance directory, the standard is .inc, whereas there are a few, but not many with .inc.php as the extension And there was a bug report submitted to fix it.
wikitech-l@lists.wikimedia.org