Hey Everyone,
I am an active contributer to Wikiversity (German and English). Over the years we realized that Mediawiki is not really providing everything a student and teacher needs in the classroom. Therefor Sebastian Schlicht and me have created a bunch of javascript, Lua modules and templates in order to pimp the user interface and some processes on the english wikiversity.
A community poll has showed that our scripts should have been moved to common.js https://en.wikiversity.org/wiki/Wikiversity_talk:MOOC_Interface#Support
The improvements can be seen live in this course: https://en.wikiversity.org/wiki/Web_Science/Part1:_Foundations_of_the_web/In...
Over the time we have realised that it would be better to create a standalone Mediawiki extension since this is more stable. So we propsed our Idea to this years fOERder award which gave us some founding for this OER (Open educational resources) related project.
Today Sebastian and I started our process. * We have been installing vagrant and have a mediawiki running locally! This is great and was well documented. * I have created: https://www.mediawiki.org/wiki/Extension:MOOC * We need a gerrit Project extension/MOOC * We need a vagrent role for this
Abraham Taherivand suggested to send a mail to this list with our needs and our introduction.
Being new in the Wikimedia world it can be a little bit confusing - even though everything is well documented - so I am sorry if we had overseen something in the documentation. So we would be really happy for support, pointers and hints and especially for a gerrit project and a vagrent role.
My username in gerrit as in other wikis is renepick
Best regards Sebastian Schlicht and Rene Pickhardt
To request a gerrit project, please visit https://www.mediawiki.org/wiki/Git/New_repositories/Requests .
On Wed, 13 Apr 2016 06:01:07 -0400, René Pickhardt r.pickhardt@googlemail.com wrote:
Hey Everyone,
I am an active contributer to Wikiversity (German and English). Over the years we realized that Mediawiki is not really providing everything a student and teacher needs in the classroom. Therefor Sebastian Schlicht and me have created a bunch of javascript, Lua modules and templates in order to pimp the user interface and some processes on the english wikiversity.
A community poll has showed that our scripts should have been moved to common.js https://en.wikiversity.org/wiki/Wikiversity_talk:MOOC_Interface#Support
The improvements can be seen live in this course: https://en.wikiversity.org/wiki/Web_Science/Part1:_Foundations_of_the_web/In...
Over the time we have realised that it would be better to create a standalone Mediawiki extension since this is more stable. So we propsed our Idea to this years fOERder award which gave us some founding for this OER (Open educational resources) related project.
Today Sebastian and I started our process.
- We have been installing vagrant and have a mediawiki running locally!
This is great and was well documented.
- I have created: https://www.mediawiki.org/wiki/Extension:MOOC
- We need a gerrit Project extension/MOOC
- We need a vagrent role for this
Abraham Taherivand suggested to send a mail to this list with our needs and our introduction.
Being new in the Wikimedia world it can be a little bit confusing - even though everything is well documented - so I am sorry if we had overseen something in the documentation. So we would be really happy for support, pointers and hints and especially for a gerrit project and a vagrent role.
My username in gerrit as in other wikis is renepick
Best regards Sebastian Schlicht and Rene Pickhardt
Dear Bahodir, dear everyone,
I have just done what you suggested thanks. How long does it usually take to get a project on gerrit? Should we use some github repo until then?
What about the vagrant role? I saw a list of them: https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles and it seems that NOT every extension has a vagrent role. Do we need this? If so where do we apply for that?
Also I forgot to mention that quite a while ago we esablished the phabricator tag https://phabricator.wikimedia.org/tag/mooc-interface/ does it make sense to continue using this one or should it be renamed to MOOC?
best Rene
On Wed, Apr 13, 2016 at 2:29 PM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
To request a gerrit project, please visit https://www.mediawiki.org/wiki/Git/New_repositories/Requests .
On Wed, 13 Apr 2016 06:01:07 -0400, René Pickhardt < r.pickhardt@googlemail.com> wrote:
Hey Everyone,
I am an active contributer to Wikiversity (German and English). Over the years we realized that Mediawiki is not really providing everything a student and teacher needs in the classroom. Therefor Sebastian Schlicht and me have created a bunch of javascript, Lua modules and templates in order to pimp the user interface and some processes on the english wikiversity.
A community poll has showed that our scripts should have been moved to common.js https://en.wikiversity.org/wiki/Wikiversity_talk:MOOC_Interface#Support
The improvements can be seen live in this course:
https://en.wikiversity.org/wiki/Web_Science/Part1:_Foundations_of_the_web/In...
Over the time we have realised that it would be better to create a standalone Mediawiki extension since this is more stable. So we propsed our Idea to this years fOERder award which gave us some founding for this OER (Open educational resources) related project.
Today Sebastian and I started our process.
- We have been installing vagrant and have a mediawiki running locally!
This is great and was well documented.
- I have created: https://www.mediawiki.org/wiki/Extension:MOOC
- We need a gerrit Project extension/MOOC
- We need a vagrent role for this
Abraham Taherivand suggested to send a mail to this list with our needs and our introduction.
Being new in the Wikimedia world it can be a little bit confusing - even though everything is well documented - so I am sorry if we had overseen something in the documentation. So we would be really happy for support, pointers and hints and especially for a gerrit project and a vagrent role.
My username in gerrit as in other wikis is renepick
Best regards Sebastian Schlicht and Rene Pickhardt
-- Baha
Hi René,
Please see my inline comments.
On Wed, 13 Apr 2016 08:55:58 -0400, René Pickhardt r.pickhardt@googlemail.com wrote:
Dear Bahodir, dear everyone,
I have just done what you suggested thanks. How long does it usually take to get a project on gerrit? Should we use some github repo until then?
From my experience it's usually a couple of days. I'd look at the page history to getter a better sense of the timing.
What about the vagrant role? I saw a list of them: https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles and it seems that NOT every extension has a vagrent role. Do we need this? If so where do we apply for that?
I don't think every extension needs a vagrant role, especially if just a few people are developing the extension and if manually setting it up is not hard. You can just clone your repo into the existing vagrant folder. If you still want to have the role created, I think your best bet is to create a phabricator task and mark it with "MediaWiki-Vagrant".
Also I forgot to mention that quite a while ago we esablished the phabricator tag https://phabricator.wikimedia.org/tag/mooc-interface/ does it make sense to continue using this one or should it be renamed to MOOC?
I don't see why not to continue using the existing project.
best Rene
On Wed, Apr 13, 2016 at 2:29 PM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
To request a gerrit project, please visit https://www.mediawiki.org/wiki/Git/New_repositories/Requests .
On Wed, 13 Apr 2016 06:01:07 -0400, René Pickhardt < r.pickhardt@googlemail.com> wrote:
Hey Everyone,
I am an active contributer to Wikiversity (German and English). Over the years we realized that Mediawiki is not really providing everything a student and teacher needs in the classroom. Therefor Sebastian Schlicht and me have created a bunch of javascript, Lua modules and templates in order to pimp the user interface and some processes on the english wikiversity.
A community poll has showed that our scripts should have been moved to common.js https://en.wikiversity.org/wiki/Wikiversity_talk:MOOC_Interface#Support
The improvements can be seen live in this course:
https://en.wikiversity.org/wiki/Web_Science/Part1:_Foundations_of_the_web/In...
Over the time we have realised that it would be better to create a standalone Mediawiki extension since this is more stable. So we propsed our Idea to this years fOERder award which gave us some founding for this OER (Open educational resources) related project.
Today Sebastian and I started our process.
- We have been installing vagrant and have a mediawiki running locally!
This is great and was well documented.
- I have created: https://www.mediawiki.org/wiki/Extension:MOOC
- We need a gerrit Project extension/MOOC
- We need a vagrent role for this
Abraham Taherivand suggested to send a mail to this list with our needs and our introduction.
Being new in the Wikimedia world it can be a little bit confusing - even though everything is well documented - so I am sorry if we had overseen something in the documentation. So we would be really happy for support, pointers and hints and especially for a gerrit project and a vagrent role.
My username in gerrit as in other wikis is renepick
Best regards Sebastian Schlicht and Rene Pickhardt
-- Baha
Hello,
On 13 April 2016 at 15:08, Bahodir Mansurov bmansurov@wikimedia.org wrote:
Hi René,
Please see my inline comments.
On Wed, 13 Apr 2016 08:55:58 -0400, René Pickhardt < r.pickhardt@googlemail.com> wrote:
Dear Bahodir, dear everyone,
I have just done what you suggested thanks. How long does it usually take to get a project on gerrit? Should we use some github repo until then?
From my experience it's usually a couple of days. I'd look at the page history to getter a better sense of the timing.
What about the vagrant role? I saw a list of them: https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles and it seems that NOT every extension has a vagrent role. Do we need this? If so where do we apply for that?
I don't think every extension needs a vagrant role, especially if just a few people are developing the extension and if manually setting it up is not hard. You can just clone your repo into the existing vagrant folder. If you still want to have the role created, I think your best bet is to create a phabricator task and mark it with "MediaWiki-Vagrant".
Right. Not everything needs a Vagrant role. However, having one definitely increases the chance of people using your extension :) As Baha suggested, you can file a new task in Phabricator and tag it with the MediaWiki-Vagrant project.
I would strongly suggest, though, to look at other extension roles and model yours after them. Just take a peek in the puppet/modules/role/manifests directory of your vagrant clone.
Also I forgot to mention that quite a while ago we esablished the phabricator tag https://phabricator.wikimedia.org/tag/mooc-interface/ does it make sense to continue using this one or should it be renamed to MOOC?
I don't see why not to continue using the existing project.
Either is fine, I think.
Cheers, Marko
best Rene
On Wed, Apr 13, 2016 at 2:29 PM, Bahodir Mansurov < bmansurov@wikimedia.org> wrote:
To request a gerrit project, please visit
https://www.mediawiki.org/wiki/Git/New_repositories/Requests .
On Wed, 13 Apr 2016 06:01:07 -0400, René Pickhardt < r.pickhardt@googlemail.com> wrote:
Hey Everyone,
I am an active contributer to Wikiversity (German and English). Over the years we realized that Mediawiki is not really providing everything a student and teacher needs in the classroom. Therefor Sebastian Schlicht and me have created a bunch of javascript, Lua modules and templates in order to pimp the user interface and some processes on the english wikiversity.
A community poll has showed that our scripts should have been moved to common.js https://en.wikiversity.org/wiki/Wikiversity_talk:MOOC_Interface#Support
The improvements can be seen live in this course:
https://en.wikiversity.org/wiki/Web_Science/Part1:_Foundations_of_the_web/In...
Over the time we have realised that it would be better to create a standalone Mediawiki extension since this is more stable. So we propsed our Idea to this years fOERder award which gave us some founding for this OER (Open educational resources) related project.
Today Sebastian and I started our process.
- We have been installing vagrant and have a mediawiki running locally!
This is great and was well documented.
- I have created: https://www.mediawiki.org/wiki/Extension:MOOC
- We need a gerrit Project extension/MOOC
- We need a vagrent role for this
Abraham Taherivand suggested to send a mail to this list with our needs and our introduction.
Being new in the Wikimedia world it can be a little bit confusing - even though everything is well documented - so I am sorry if we had overseen something in the documentation. So we would be really happy for support, pointers and hints and especially for a gerrit project and a vagrent role.
My username in gerrit as in other wikis is renepick
Best regards Sebastian Schlicht and Rene Pickhardt
-- Baha
-- Baha
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On 04/13/2016 09:21 AM, Marko Obrovac wrote:
Right. Not everything needs a Vagrant role. However, having one definitely increases the chance of people using your extension :) As Baha suggested, you can file a new task in Phabricator and tag it with the MediaWiki-Vagrant project.
Yes. A good example of a very simple role is role::doublewiki (but please put a better description than that). If your extension needs update.php, grep for needs_update. role::cite is almost as simple, but shows how config settings work.
And you can feel free to ask on Phabricator or here for help.
Matt
Hey everyone,
and thanks for your help so far. We continued setting up our working environment and have a couple more questions especially regarding the code review process:
Obviously we need some place to store code during development and exchange code without third party reviewing of every commit. Is giving us push rights in our gerrit project for developing on a develop branch and asking for code reviews via the mailing list before merging to the master branch the correct process? Or should we develop and exchange code for example in a github repository and only push patches to gerrit and then ask someone for code review?
Background where we are coming from:
Sebastian and I are now project owners for https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MOOC this can be seen from: https://gerrit.wikimedia.org/r/#/admin/groups/1184,members In the beginning we could not exchange code by pushing changes to the develop branch but could only push to new branches. we could fix this by adding push rights to the extension-MOOC group Now we are confused! On https://www.mediawiki.org/wiki/Gerrit/%2B2 we read that we should not +2 our own code - even if we are project owners. in IRC we had the following conversation that suggested otherwise:
[10:22] <legoktm> renepick: it's designed for merge review...so you upload the patch using git review (or the magical git push origin HEAD:refs/for/master) which uploads it to gerrit for review, which you then +2 [10:30] <renepick> @legoktm: on the docu it says that one should not self +2 ones own code [10:30] <legoktm> that's an ideal, but it really depends on whether you have someone else to review your code for you
Obviously today we just played around with sample code and rights management in gerrit. So we do not have something for review even though there where some commits. But it is important for us and our future development process to understand the customs and processes that are going on here.
best regards Rene
On Fri, Apr 15, 2016 at 12:34 AM, Matthew Flaschen mflaschen@wikimedia.org wrote:
On 04/13/2016 09:21 AM, Marko Obrovac wrote:
Right. Not everything needs a Vagrant role. However, having one definitely increases the chance of people using your extension :) As Baha suggested, you can file a new task in Phabricator and tag it with the MediaWiki-Vagrant project.
Yes. A good example of a very simple role is role::doublewiki (but please put a better description than that). If your extension needs update.php, grep for needs_update. role::cite is almost as simple, but shows how config settings work.
And you can feel free to ask on Phabricator or here for help.
Matt
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Wed, Apr 13, 2016 at 6:08 AM Bahodir Mansurov bmansurov@wikimedia.org wrote:
Hi René,
Please see my inline comments.
On Wed, 13 Apr 2016 08:55:58 -0400, René Pickhardt r.pickhardt@googlemail.com wrote:
Dear Bahodir, dear everyone,
I have just done what you suggested thanks. How long does it usually take to get a project on gerrit? Should we use some github repo until then?
From my experience it's usually a couple of days. I'd look at the page history to getter a better sense of the timing.
Already done: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MOOC
-Chad
Hey Chad,
I do not get the sense of your message. The MOOC project in gerrit exists. My question was more about how we are supposed to use it with respect to +2 rights and code review.
best Rene
On Wed, Apr 20, 2016 at 3:42 PM, Chad innocentkiller@gmail.com wrote:
On Wed, Apr 13, 2016 at 6:08 AM Bahodir Mansurov bmansurov@wikimedia.org wrote:
Hi René,
Please see my inline comments.
On Wed, 13 Apr 2016 08:55:58 -0400, René Pickhardt r.pickhardt@googlemail.com wrote:
Dear Bahodir, dear everyone,
I have just done what you suggested thanks. How long does it usually
take
to get a project on gerrit? Should we use some github repo until then?
From my experience it's usually a couple of days. I'd look at the page history to getter a better sense of the timing.
Already done: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MOOC
-Chad _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Wed, Apr 20, 2016 at 7:09 AM René Pickhardt r.pickhardt@googlemail.com wrote:
Hey Chad,
I do not get the sense of your message. The MOOC project in gerrit exists. My question was more about how we are supposed to use it with respect to +2 rights and code review.
Hi Rene,
You and Sebastian already have permissions on that repository :)
-Chad
Hey Chad,
I understand this but I also understand the documentation ( https://www.mediawiki.org/wiki/%2B2 ) in a way that it says that Sebastian and me should not review our own code. That is where my question was aiming. Because obviously even with early code review we do not need every time we make a git commit to exchange our work in our team a code review.
best Rene
On Wed, Apr 20, 2016 at 4:15 PM, Chad innocentkiller@gmail.com wrote:
On Wed, Apr 20, 2016 at 7:09 AM René Pickhardt <r.pickhardt@googlemail.com
wrote:
Hey Chad,
I do not get the sense of your message. The MOOC project in gerrit
exists.
My question was more about how we are supposed to use it with respect to
+2
rights and code review.
Hi Rene,
You and Sebastian already have permissions on that repository :)
-Chad _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Wed, Apr 20, 2016 at 8:26 AM, René Pickhardt r.pickhardt@googlemail.com wrote:
Hey Chad,
I understand this but I also understand the documentation ( https://www.mediawiki.org/wiki/%2B2 ) in a way that it says that Sebastian and me should not review our own code. That is where my question was aiming. Because obviously even with early code review we do not need every time we make a git commit to exchange our work in our team a code review.
Waiting for peer code review on each patch can be very difficult when working on a small team and doing new development. Self-merges are generally ok when you are building something new from scratch that isn't deployed into the WMF production yet. All of your code will eventually need to get a full security and performance review before being approved for WMF production use. Find a workflow that works for you and your collaborators and don't get too hung up on the guidance that we give for production deployed code yet.
Bryan
Hey Bryan,
that is great to hear! Though this development has the clear goal to transfer our MOOC-Interface which is in use on wikiversity to production code as an extension. Therefor we wanted to involve the community right a way and adapt to the processes that are the common culture here.
best Rene
On Wed, Apr 20, 2016 at 5:21 PM, Bryan Davis bd808@wikimedia.org wrote:
On Wed, Apr 20, 2016 at 8:26 AM, René Pickhardt r.pickhardt@googlemail.com wrote:
Hey Chad,
I understand this but I also understand the documentation ( https://www.mediawiki.org/wiki/%2B2 ) in a way that it says that
Sebastian
and me should not review our own code. That is where my question was aiming. Because obviously even with early code review we do not need
every
time we make a git commit to exchange our work in our team a code review.
Waiting for peer code review on each patch can be very difficult when working on a small team and doing new development. Self-merges are generally ok when you are building something new from scratch that isn't deployed into the WMF production yet. All of your code will eventually need to get a full security and performance review before being approved for WMF production use. Find a workflow that works for you and your collaborators and don't get too hung up on the guidance that we give for production deployed code yet.
Bryan
Bryan Davis Wikimedia Foundation bd808@wikimedia.org [[m:User:BDavis_(WMF)]] Sr Software Engineer Boise, ID USA irc: bd808 v:415.839.6885 x6855
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On 13.04.2016 14:55, René Pickhardt wrote:
Dear Bahodir, dear everyone,
I have just done what you suggested thanks. How long does it usually take to get a project on gerrit? Should we use some github repo until then?
Not needed for a short time :)
What about the vagrant role? I saw a list of them: https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Roles and it seems that NOT every extension has a vagrent role. Do we need this? If so where do we apply for that?
Also I forgot to mention that quite a while ago we esablished the phabricator tag https://phabricator.wikimedia.org/tag/mooc-interface/ does it make sense to continue using this one or should it be renamed to MOOC?
best Rene
On Wed, Apr 13, 2016 at 2:29 PM, Bahodir Mansurov bmansurov@wikimedia.org wrote:
To request a gerrit project, please visit https://www.mediawiki.org/wiki/Git/New_repositories/Requests .
On Wed, 13 Apr 2016 06:01:07 -0400, René Pickhardt < r.pickhardt@googlemail.com> wrote:
Hey Everyone,
I am an active contributer to Wikiversity (German and English). Over the years we realized that Mediawiki is not really providing everything a student and teacher needs in the classroom. Therefor Sebastian Schlicht and me have created a bunch of javascript, Lua modules and templates in order to pimp the user interface and some processes on the english wikiversity.
A community poll has showed that our scripts should have been moved to common.js
https://en.wikiversity.org/wiki/Wikiversity_talk:MOOC_Interface#Support
The improvements can be seen live in this course:
https://en.wikiversity.org/wiki/Web_Science/Part1:_Foundations_of_the_web/In...
Over the time we have realised that it would be better to create a standalone Mediawiki extension since this is more stable. So we propsed our Idea to this years fOERder award which gave us some founding for this OER (Open educational resources) related project.
Today Sebastian and I started our process.
- We have been installing vagrant and have a mediawiki running
locally! This is great and was well documented.
- I have created: https://www.mediawiki.org/wiki/Extension:MOOC
- We need a gerrit Project extension/MOOC
- We need a vagrent role for this
Abraham Taherivand suggested to send a mail to this list with our needs and our introduction.
Being new in the Wikimedia world it can be a little bit confusing - even though everything is well documented - so I am sorry if we had overseen something in the documentation. So we would be really happy for support, pointers and hints and especially for a gerrit project and a vagrent role.
My username in gerrit as in other wikis is renepick
Best regards Sebastian Schlicht and Rene Pickhardt
-- Baha
wikitech-l@lists.wikimedia.org