Hi MediaWiki devs,
I just noticed that the UploadForm:BeforeProcessing hook appears to be deprecated in comments in the codebase[1], but that this deprecation is not mentioned in the documentation[2].
What is the alternative? I have an extension which implements a paste feature which uses this hook to create a temp file from base64 encoded clipboard data.
Thanks in advance for any feedback.
[1] http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/Spe... [2] http://www.mediawiki.org/wiki/Manual:Hooks/UploadForm:BeforeProcessing
-- Jim R. Wilson (jimbojw)
On Mon, Nov 8, 2010 at 9:36 PM, Jim R. Wilson wilson.jim.r@gmail.com wrote:
I just noticed that the UploadForm:BeforeProcessing hook appears to be deprecated in comments in the codebase[1], but that this deprecation is not mentioned in the documentation[2].
As per our conversation on IRC: the hook was deprecated because I was under the impression that it was used to break upload processing without showing any information to the user, which is BAD. I overlooked the fact that it was also used for other purposes, so I undeprecated it in r76341 [1].
Bryan
[1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76341
Thanks Bryan!
On Mon, Nov 8, 2010 at 4:38 PM, Bryan Tong Minh bryan.tongminh@gmail.comwrote:
On Mon, Nov 8, 2010 at 9:36 PM, Jim R. Wilson wilson.jim.r@gmail.com wrote:
I just noticed that the UploadForm:BeforeProcessing hook appears to be deprecated in comments in the codebase[1], but that this deprecation is
not
mentioned in the documentation[2].
As per our conversation on IRC: the hook was deprecated because I was under the impression that it was used to break upload processing without showing any information to the user, which is BAD. I overlooked the fact that it was also used for other purposes, so I undeprecated it in r76341 [1].
Bryan
[1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76341
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org