Hello,
For a long time now we have been reviewing changes that contains unwanted trailing whitespaces. To make sure the patch submitter is warned about it, I have enabled trailing whitespace check on mediawiki/core.git
The bug report is: https://bugzilla.wikimedia.org/42628
I have only enabled such check on the mediawiki/core.git repository for now. If that went well I will look up at enabling it on other repos.
cheer,
On Fri, Dec 21, 2012 at 9:43 AM, Antoine Musso hashar+wmf@free.fr wrote:
Hello,
For a long time now we have been reviewing changes that contains unwanted trailing whitespaces. To make sure the patch submitter is warned about it, I have enabled trailing whitespace check on mediawiki/core.git
The bug report is: https://bugzilla.wikimedia.org/42628
I have only enabled such check on the mediawiki/core.git repository for now. If that went well I will look up at enabling it on other repos.
Is this a warning, or a failure? I really don't think we should *fail* patches for something that's almost always harmless. The only reason I ask is because you say warning here but failure on the bug.
-Chad
It should be an ignorable warning.
There are occasionally situations where trailing white space is necessary. MySQL for instance can be funny about combining multi line strings into one query, although I don't think it presents when called via PHP.
Luke
On Fri, Dec 21, 2012 at 9:59 AM, Chad innocentkiller@gmail.com wrote:
On Fri, Dec 21, 2012 at 9:43 AM, Antoine Musso hashar+wmf@free.fr wrote:
Hello,
For a long time now we have been reviewing changes that contains unwanted trailing whitespaces. To make sure the patch submitter is warned about it, I have enabled trailing whitespace check on mediawiki/core.git
The bug report is: https://bugzilla.wikimedia.org/42628
I have only enabled such check on the mediawiki/core.git repository for now. If that went well I will look up at enabling it on other repos.
Is this a warning, or a failure? I really don't think we should *fail* patches for something that's almost always harmless. The only reason I ask is because you say warning here but failure on the bug.
-Chad
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
And PS, as I've been dinged for this a few times this is now in my .vimrc to highlight trailing whitespace in vim.
highlight ExtraWhitespace ctermbg=red guibg=red match ExtraWhitespace /\s+$/ autocmd BufWInEnter * match ExtraWhitespace /\s+$/ autocmd InsertEnter * match ExtraWhitespace /\s+%#@<!$/ autocmd InsertLeave * match ExtraWhitespace /\s+$/ autocmd BufWInLeave * call clearmatches()
On Fri, Dec 21, 2012 at 10:20 AM, Luke Welling WMF lwelling@wikimedia.orgwrote:
It should be an ignorable warning.
There are occasionally situations where trailing white space is necessary. MySQL for instance can be funny about combining multi line strings into one query, although I don't think it presents when called via PHP.
Luke
On Fri, Dec 21, 2012 at 9:59 AM, Chad innocentkiller@gmail.com wrote:
On Fri, Dec 21, 2012 at 9:43 AM, Antoine Musso hashar+wmf@free.fr wrote:
Hello,
For a long time now we have been reviewing changes that contains unwanted trailing whitespaces. To make sure the patch submitter is warned about it, I have enabled trailing whitespace check on mediawiki/core.git
The bug report is: https://bugzilla.wikimedia.org/42628
I have only enabled such check on the mediawiki/core.git repository for now. If that went well I will look up at enabling it on other repos.
Is this a warning, or a failure? I really don't think we should *fail* patches for something that's almost always harmless. The only reason I ask is because you say warning here but failure on the bug.
-Chad
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Le 21/12/12 15:59, Chad a écrit :
Is this a warning, or a failure? I really don't think we should *fail* patches for something that's almost always harmless. The only reason I ask is because you say warning here but failure on the bug.
Ah true. Hmm I will back it off so and probably going to make the whitelist check an independant job that would not vote on failure. That would be for next year :)
wikitech-l@lists.wikimedia.org