A few questions/remarks/observations: * why add an SVN executable property to all files? (I have removed them) * the phpmailer version included in this extensions is 1.73 and dates from Jun 10 2005 according to ChangeLog.txt. Are you certain it is a good idea to add code this old? The current version of phpmailer is 2.0.0 and dates from 2 December 2007. [1], [2]

Cheers! Siebrand

[1] http://phpmailer.codeworxtech.com/ [2] http://sourceforge.net/project/showfiles.php?group_id=26031

-----Oorspronkelijk bericht----- Van: mediawiki-cvs-bounces@lists.wikimedia.org Verzonden: zaterdag 17 mei 2008 12:13 Aan: mediawiki-cvs@lists.wikimedia.org Onderwerp: [MediaWiki-CVS] SVN: [34965] trunk/extensions

Revision: 34965 Author: nad Date: 2008-05-17 10:13:04 +0000 (Sat, 17 May 2008)

Log Message: ----------- Moving here from http://www.organicdesign.co.nz/Extension:EmailArticle.php

Added Paths: ----------- trunk/extensions/EmailArticle/ trunk/extensions/EmailArticle/EmailArticle.php trunk/extensions/EmailArticle/phpmailer/ trunk/extensions/EmailArticle/phpmailer/ChangeLog.txt trunk/extensions/EmailArticle/phpmailer/LICENSE trunk/extensions/EmailArticle/phpmailer/class.smtp.php trunk/extensions/EmailArticle/phpmailer/docs/ trunk/extensions/EmailArticle/phpmailer/docs/extending.html trunk/extensions/EmailArticle/phpmailer/docs/faq.html trunk/extensions/EmailArticle/phpmailer/docs/timeoutfix.diff trunk/extensions/EmailArticle/phpmailer/language/ trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-ca.php trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-de.php trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-dk.php trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-en.php trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-fo.php trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-no.php trunk/extensions/EmailArticle/phpmailer/language/phpmailer.lang-tr.php