Rob, thanks for the heads up on the release notes (although it is not a breaking functionality - the original format of the message will continue to work). As for the DB -- the case almost never happens (you always have a disambig template listed), plus its a batch process, so it does not get run very often. Lastly, the way the QueryPage class is structured, I did not see an easy way to return an empty result without calling the server.

Where do we keep the release notes?

--Yurik

On 8/25/06, Rob Church robchur@gmail.com wrote:

On 25/08/06, yurik@svn.leuksman.com yurik@svn.leuksman.com wrote:

...

Revision: 16217 Author: yurik Date: 2006-08-24 21:32:33 -0700 (Thu, 24 Aug 2006)

Log Message:

• Now [[MediaWiki:Disambiguationspage]] may have either disambig

template name, or a list of links to disambig templates.

For what purpose?

...

•    if( $set === false ) {
  

•        $set = 'FALSE';  # We must always return a valid sql query,
  

but this way DB will always quicly return an empty result

Don't issue the SELECT at all in that case, it's a waste of a database connection.

You didn't update the release notes. This is a change which will affect the user's use of that message, plus the behaviour of the page; the release notes MUST be updated.

Rob Church _______________________________________________ Wikitech-l mailing list Wikitech-l@wikimedia.org http://mail.wikipedia.org/mailman/listinfo/wikitech-l