tbleher@svn.wikimedia.org schrieb:
Revision: 40817 Author: tbleher Date: 2008-09-14 14:24:54 +0000 (Sun, 14 Sep 2008)
Log Message:
Escape $1 in message (was PHP syntax error)
Modified: trunk/phase3/includes/api/ApiBase.php
--- trunk/phase3/includes/api/ApiBase.php 2008-09-14 12:25:53 UTC (rev 40816) +++ trunk/phase3/includes/api/ApiBase.php 2008-09-14 14:24:54 UTC (rev 40817) @@ -700,7 +700,7 @@ 'permdenied-undelete' => array('code' => 'permissiondenied', 'info' => "You don't have permission to restore deleted revisions"), 'createonly-exists' => array('code' => 'articleexists', 'info' => "The article you tried to create has been created already"), 'nocreate-missing' => array('code' => 'missingtitle', 'info' => "The article you tried to edit doesn't exist"),
'nosuchrcid' => array('code' => 'nosuchrcid', 'info' => "There is no change with rcid ``$1''"),
'nosuchrcid' => array('code' => 'nosuchrcid', 'info' => "There is no change with rcid ``\$1''"),
This looks still wrong: Shouldn't it be ''$1'' instead of ``$1'' ?
Raymond.
Raimond Spekking schreef:
tbleher@svn.wikimedia.org schrieb:
Revision: 40817 Author: tbleher Date: 2008-09-14 14:24:54 +0000 (Sun, 14 Sep 2008)
Log Message:
Escape $1 in message (was PHP syntax error)
Modified: trunk/phase3/includes/api/ApiBase.php
--- trunk/phase3/includes/api/ApiBase.php 2008-09-14 12:25:53 UTC (rev 40816) +++ trunk/phase3/includes/api/ApiBase.php 2008-09-14 14:24:54 UTC (rev 40817) @@ -700,7 +700,7 @@ 'permdenied-undelete' => array('code' => 'permissiondenied', 'info' => "You don't have permission to restore deleted revisions"), 'createonly-exists' => array('code' => 'articleexists', 'info' => "The article you tried to create has been created already"), 'nocreate-missing' => array('code' => 'missingtitle', 'info' => "The article you tried to edit doesn't exist"),
'nosuchrcid' => array('code' => 'nosuchrcid', 'info' => "There is no change with rcid ``$1''"),
'nosuchrcid' => array('code' => 'nosuchrcid', 'info' => "There is no change with rcid ``\$1''"),This looks still wrong: Shouldn't it be ''$1'' instead of ``$1'' ?
No, it's not like it's wikitext. The ``foo'' convention is used throughout the API.
Roan Kattouw (Catrope)
* Raimond Spekking raimond.spekking@gmail.com [2008-09-14 17:44]:
tbleher@svn.wikimedia.org schrieb:
Revision: 40817 Author: tbleher Date: 2008-09-14 14:24:54 +0000 (Sun, 14 Sep 2008)
Log Message:
Escape $1 in message (was PHP syntax error)
Modified: trunk/phase3/includes/api/ApiBase.php
--- trunk/phase3/includes/api/ApiBase.php 2008-09-14 12:25:53 UTC (rev 40816) +++ trunk/phase3/includes/api/ApiBase.php 2008-09-14 14:24:54 UTC (rev 40817) @@ -700,7 +700,7 @@ 'permdenied-undelete' => array('code' => 'permissiondenied', 'info' => "You don't have permission to restore deleted revisions"), 'createonly-exists' => array('code' => 'articleexists', 'info' => "The article you tried to create has been created already"), 'nocreate-missing' => array('code' => 'missingtitle', 'info' => "The article you tried to edit doesn't exist"),
'nosuchrcid' => array('code' => 'nosuchrcid', 'info' => "There is no change with rcid ``$1''"),
'nosuchrcid' => array('code' => 'nosuchrcid', 'info' => "There is no change with rcid ``\$1''"),This looks still wrong: Shouldn't it be ''$1'' instead of ``$1'' ?
I don't think so. It's consistent with the other error messages in the file. As far as I can see the only transformation done on the message is replacement of the $n placeholders. So ``'' is used for quoting, not italicization.
Regards, Thomas Bleher
wikitech-l@lists.wikimedia.org