When running `composer update` MediaWiki injects a mediawiki/mediawiki package, so extensions can declare a dependency on a particular MW version range. However, when doing a `composer update --dry-run` this package gets not injected causing the dry run to fail.
Does anybody know a solution/workaround?
Stephan
as far as I know, extensions shouldn't be declaring a dependency on MediaWiki in composer.json and if one is, it should probably be fixed.
On Fri, Nov 15, 2019 at 9:50 AM Stephan Gambke via Wikitech-l < wikitech-l@lists.wikimedia.org> wrote:
When running `composer update` MediaWiki injects a mediawiki/mediawiki package, so extensions can declare a dependency on a particular MW version range. However, when doing a `composer update --dry-run` this package gets not injected causing the dry run to fail.
Does anybody know a solution/workaround?
Stephan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
See https://github.com/wikimedia/mediawiki/commit/3307d4957925df319df2b84cfc3e6f...
"This change allows extensions to specify they depend on a specific version or version range of MediaWiki. This is done by adding the package mediawiki/mediawiki in their composer.json require section."
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, November 15, 2019 4:15 PM, David Barratt dbarratt@wikimedia.org wrote:
as far as I know, extensions shouldn't be declaring a dependency on MediaWiki in composer.json and if one is, it should probably be fixed.
On Fri, Nov 15, 2019 at 9:50 AM Stephan Gambke via Wikitech-l wikitech-l@lists.wikimedia.org wrote:
When running `composer update` MediaWiki injects a mediawiki/mediawiki package, so extensions can declare a dependency on a particular MW version range. However, when doing a `composer update --dry-run` this package gets not injected causing the dry run to fail.
Does anybody know a solution/workaround?
Stephan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
That was six years ago, predating extension registration – I would assume that nowadays extensions are supposed to declare their compatible MediaWiki versions in extension.json https://www.mediawiki.org/wiki/Manual:Extension_registration#Requirements_(dependencies) (details https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#requires).
Cheers, Lucas
Am Fr., 15. Nov. 2019 um 16:38 Uhr schrieb Stephan Gambke via Wikitech-l < wikitech-l@lists.wikimedia.org>:
See https://github.com/wikimedia/mediawiki/commit/3307d4957925df319df2b84cfc3e6f...
"This change allows extensions to specify they depend on a specific version or version range of MediaWiki. This is done by adding the package mediawiki/mediawiki in their composer.json require section."
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, November 15, 2019 4:15 PM, David Barratt < dbarratt@wikimedia.org> wrote:
as far as I know, extensions shouldn't be declaring a dependency on
MediaWiki in composer.json and if one is, it should probably be fixed.
On Fri, Nov 15, 2019 at 9:50 AM Stephan Gambke via Wikitech-l <
wikitech-l@lists.wikimedia.org> wrote:
When running `composer update` MediaWiki injects a mediawiki/mediawiki
package, so extensions can declare a dependency on a particular MW version range.
However, when doing a `composer update --dry-run` this package gets not
injected causing the dry run to fail.
Does anybody know a solution/workaround?
Stephan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Fri, Nov 15, 2019 at 11:06 AM Lucas Werkmeister < lucas.werkmeister@wikimedia.de> wrote:
That was six years ago, predating extension registration – I would assume that nowadays extensions are supposed to declare their compatible MediaWiki versions in extension.json < https://www.mediawiki.org/wiki/Manual:Extension_registration#Requirements_(d...)
(details https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#requires).
It also predated T467 RfC: Extension management with Composer https://phabricator.wikimedia.org/T467, which rejected the proposal to manage extensions via composer.
I think you assume correctly.
On Fri, Nov 15, 2019 at 8:16 AM Brad Jorsch (Anomie) bjorsch@wikimedia.org wrote:
It also predated T467 RfC: Extension management with Composer https://phabricator.wikimedia.org/T467, which rejected the proposal to manage extensions via composer.
Which raises the question: should this functionality stay in MediaWiki at all?
Where does the mediawiki/mediawiki package come from? It's no longer on Packagist; how does Composer know where to get it? It should certainly not appear as a requirement for any package.
As for removing the functionality: do you mean the functionality of the Composer merge plugin? i.e. that we can load dependencies in the MediaWiki root directory, rather than within each extension's directory?
On 15/11/19 7:16 pm, Max Semenik wrote:
On Fri, Nov 15, 2019 at 8:16 AM Brad Jorsch (Anomie) bjorsch@wikimedia.org wrote:
It also predated T467 RfC: Extension management with Composer https://phabricator.wikimedia.org/T467, which rejected the proposal to manage extensions via composer.
Which raises the question: should this functionality stay in MediaWiki at all?
On Fri, Nov 15, 2019 at 7:19 PM Sam Wilson sam@samwilson.id.au wrote:
Where does the mediawiki/mediawiki package come from? It's no longer on Packagist; how does Composer know where to get it? It should certainly not appear as a requirement for any package.
ComposerHookHandler adds it programmatically.
As for removing the functionality: do you mean the functionality of the
Composer merge plugin? i.e. that we can load dependencies in the MediaWiki root directory, rather than within each extension's directory?
I mean ComposerHookHandler and friends.
On Fri, Nov 15, 2019 at 4:16 PM Max Semenik maxsem.wiki@gmail.com wrote:
Which raises the question: should this functionality stay in MediaWiki at all?
I've pushed https://gerrit.wikimedia.org/r/551346 for review.
Best regards, Max Semenik ([[User:MaxSem]])
wikitech-l@lists.wikimedia.org