-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
We've been getting a *lot* more complaints about bad diff renderings in the last couple days, which may be related to the recent upgrade of the wikidiff2 extension (triggered by PHP upgrades on the Fedora servers).
Some notes on my quest to track it down:
https://wikitech.leuksman.com/view/Diff_hell
I don't have a lot of data points, but:
* 1000 test hits total * all hits used wikidiff2 extension * 515 hits were to Fedora machines * 8 Fedora hits gave bogus results * quick command-line-based tests didn't have any failures
The Ubuntu boxes are running a slightly older version of wikidiff2 which doesn't add the inline classes, but that shouldn't make any difference.
- -- brion vibber (brion @ wikimedia.org)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Brion Vibber wrote:
I don't have a lot of data points, but:
- 1000 test hits total
- all hits used wikidiff2 extension
- 515 hits were to Fedora machines
- 8 Fedora hits gave bogus results
- quick command-line-based tests didn't have any failures
I made a more thorough log with a quick hack to MediaWiki -- run each diff twice, then log it if they didn't match.
With this larger sample size, I was able to narrow down the problem to Fedora Core *4* machines; Fedora 3 boxes were unaffected.
This made me suspect a C++ version library mismatch or some other silly thing perhaps caused by installing a single binary across OS versions, so I rebuilt our wikidiff2 RPM separately on FC3 and FC4, and made sure the FC4 boxes were running the FC4 version.
The bad log entries immediately dried up, so.... so far so good. :)
- -- brion vibber (brion @ wikimedia.org)
Brion Vibber wrote:
This made me suspect a C++ version library mismatch or some other silly thing perhaps caused by installing a single binary across OS versions, so I rebuilt our wikidiff2 RPM separately on FC3 and FC4, and made sure the FC4 boxes were running the FC4 version.
The bad log entries immediately dried up, so.... so far so good. :)
- -- brion vibber (brion @ wikimedia.org)
Congratulations. You did a good job catching it :) It was an awkward problem.
wikitech-l@lists.wikimedia.org