Revision: 25083 Author: raymond Date: 2007-08-23 10:52:51 +0000 (Thu, 23 Aug 2007)
Log Message:
Fix for r25082. Access key for preferences changed to '9'. Access key ',' is already in use for the textarea of the edit form, but hard coded. Is there a special reason not to use the normal access key/tooltip mechanism? Thanks to WebBoy.
Modified Paths:
trunk/phase3/languages/messages/MessagesEn.phpModified: trunk/phase3/languages/messages/MessagesEn.php
--- trunk/phase3/languages/messages/MessagesEn.php 2007-08-23 09:34:33 UTC (rev 25082) +++ trunk/phase3/languages/messages/MessagesEn.php 2007-08-23 10:52:51 UTC (rev 25083) @@ -2241,7 +2241,7 @@ 'accesskey-pt-anonuserpage' => '.', # don't translate or duplicate this message to other languages 'accesskey-pt-mytalk' => 'n', # don't translate or duplicate this message to other languages 'accesskey-pt-anontalk' => 'n', # don't translate or duplicate this message to other languages -'accesskey-pt-preferences' => ',', # don't translate or duplicate this message to other languages +'accesskey-pt-preferences' => '9', # don't translate or duplicate this message to other languages 'accesskey-pt-watchlist' => 'l', # don't translate or duplicate this message to other languages 'accesskey-pt-mycontris' => 'y', # don't translate or duplicate this message to other languages 'accesskey-pt-login' => 'o', # don't translate or duplicate this message to other languages
This breaks typing characters with Alt+numeric code, as you end up at Special:Preferences. Please reassign a non-numeric character.
Follow-up: ',' was added on the previous revision (r25082), it didn't have an accesskey before, which is bug 5206.
On 8/31/07, Platonides Platonides@gmail.com wrote:
This breaks typing characters with Alt+numeric code, as you end up at Special:Preferences. Please reassign a non-numeric character.
Follow-up: ',' was added on the previous revision (r25082), it didn't have an accesskey before, which is bug 5206.
Yeah, Firefox screws up with numeric codes. They shouldn't be used.
On 9/1/07, Simetrical Simetrical+wikilist@gmail.com wrote:
Yeah, Firefox screws up with numeric codes. They shouldn't be used.
(Well, at least before the combination key changed from Alt- to Alt-Shift-. IE not unlikely gets this wrong too.)
Platonides schrieb:
Revision: 25083
This breaks typing characters with Alt+numeric code, as you end up at Special:Preferences. Please reassign a non-numeric character.
Follow-up: ',' was added on the previous revision (r25082), it didn't have an accesskey before, which is bug 5206.
Sorry, I am not aware about problems with numeric codes. I have used 9 because it's optically similar to 'P' for preferences but P is already used for preview in edit mode.
Any suggestion for another key?
My first thought (r25082) was ',' but this access key is hard coded for the edit form field (BTW: why is it hard coded?).
Another issue I have found is the access key '=' for protecting a page. At least with Firefox2/WinXp, which uses crtl-shift as access key combination, the '=' access key is not longer reachable.
Any suggestions for a change/reassign?
Raymond.
Raimond Spekking wrote:
Sorry, I am not aware about problems with numeric codes. I have used 9 because it's optically similar to 'P' for preferences but P is already used for preview in edit mode.
Any suggestion for another key?
My first thought (r25082) was ',' but this access key is hard coded for the edit form field (BTW: why is it hard coded?).
Just remove it; it's hardly something you're going to do constantly, so it really doesn't need a shortcut key.
-- brion vibber (brion @ wikimedia.org)
wikitech-l@lists.wikimedia.org