On Tue, Apr 15, 2008 at 4:44 PM, catrope@svn.wikimedia.org wrote:
Log Message:
Adding CSS class for nested <fieldset>s. Nesting fieldsets used to cause a huge amount of whitespace between the parent and the child fieldset, this commit adds a class that circumvents this.
Modified Paths:
trunk/phase3/RELEASE-NOTES trunk/phase3/includes/DefaultSettings.php trunk/phase3/skins/monobook/main.css
1) Why can't you just use the selector "fieldset fieldset" to pick up nesting instead of adding yet another class? For that matter, there's enough support for appropriate selectors now that "fieldset > fieldset" would be fine, I think (since this is a minor aesthetic issue, IE6 users can live with it).
2) You don't seem to have actually added the class to any fieldsets . . .
Simetrical schreef:
- Why can't you just use the selector "fieldset fieldset" to pick up
nesting instead of adding yet another class? For that matter, there's enough support for appropriate selectors now that "fieldset > fieldset" would be fine, I think (since this is a minor aesthetic issue, IE6 users can live with it).
I didn't know that was possible, I'm not a CSS expert. Besides, you might also want to use the nested class for fieldsets in tables, because they also show exorbitant spacing under some conditions (such as two fieldsets placed in separate <tr>s, one immediately below the other, something that actually happened for me).
- You don't seem to have actually added the class to any fieldsets . . .
I used it in an extension that I'll probably finish next week.
Roan Kattouw (Catrope)
wikitech-l@lists.wikimedia.org